From fb74e1c7374132bc7570ba56b1619a0d8095f98f Mon Sep 17 00:00:00 2001
From: Ivica Ico Bukvic <ico@vt.edu>
Date: Tue, 8 Sep 2020 10:32:43 -0400
Subject: [PATCH] Minor dialog improvements

* Prefs top tab bar is now stretched across the full window width

* All close buttons are a bit better spaced from the right edge, so that the top and right and bottom edges are as similar as possible
---
 pd/nw/css/default.css      | 9 +++------
 pd/nw/dialog_canvas.html   | 2 +-
 pd/nw/dialog_data.html     | 2 +-
 pd/nw/dialog_external.html | 2 +-
 pd/nw/dialog_gatom.html    | 2 +-
 pd/nw/dialog_iemgui.html   | 2 +-
 pd/nw/dialog_prefs.html    | 2 +-
 7 files changed, 9 insertions(+), 12 deletions(-)

diff --git a/pd/nw/css/default.css b/pd/nw/css/default.css
index a29812f32..3bb627dcc 100644
--- a/pd/nw/css/default.css
+++ b/pd/nw/css/default.css
@@ -759,7 +759,7 @@ div.y2 {
    without becoming an order of magnitude more complex, do feel free... */
 .prefs_tab_group {
     display: table;
-    width: 96%;
+    width: 100%;
 }
 
 /* Configure the radio buttons to hide off-screen */
@@ -856,11 +856,8 @@ input[name="rate"] {
     cursor: grab;
 }
 
-#titlebar_buttons {
-    top: 2px;
-    right: 2px;
-    text-align: right;
-    background-color: gray;
+#titlebar_buttons_td {
+    padding-right: 1px;
 }
 
 #titlebar_title {
diff --git a/pd/nw/dialog_canvas.html b/pd/nw/dialog_canvas.html
index fdc41dfb0..c5f31c215 100644
--- a/pd/nw/dialog_canvas.html
+++ b/pd/nw/dialog_canvas.html
@@ -12,7 +12,7 @@
           <td style="width: 100%;">
             <div id="titlebar_title">Canvas Properties</div>
           </td>
-          <td>
+          <td id="titlebar_buttons_td">
             <div class="titlebar_buttons">
               <div id="titlebar_close_button" onclick="cancel(false);">&#215</div>
             </div>
diff --git a/pd/nw/dialog_data.html b/pd/nw/dialog_data.html
index aa39420af..88eb5b150 100644
--- a/pd/nw/dialog_data.html
+++ b/pd/nw/dialog_data.html
@@ -45,7 +45,7 @@ label {
           <td style="width: 100%;">
             <div id="titlebar_title">Data Object Properties</div>
           </td>
-          <td>
+          <td id="titlebar_buttons_td">
             <div class="titlebar_buttons">
               <div id="titlebar_close_button" onclick="cancel(false);">&#215</div>
             </div>
diff --git a/pd/nw/dialog_external.html b/pd/nw/dialog_external.html
index a2c73209e..28e4d3f9e 100644
--- a/pd/nw/dialog_external.html
+++ b/pd/nw/dialog_external.html
@@ -43,7 +43,7 @@ label {
           <td style="width: 100%; margin: 7px;">
             <div id="titlebar_title">External Object Properties</div>
           </td>
-          <td>
+          <td id="titlebar_buttons_td">
             <div class="titlebar_buttons">
               <div id="titlebar_close_button" onclick="cancel(false);">&#215</div>
             </div>
diff --git a/pd/nw/dialog_gatom.html b/pd/nw/dialog_gatom.html
index f02bfb3b7..fd6a1d8de 100644
--- a/pd/nw/dialog_gatom.html
+++ b/pd/nw/dialog_gatom.html
@@ -10,7 +10,7 @@
           <td style="width: 100%;">
             <div id="titlebar_title">Atom Properties</div>
           </td>
-          <td>
+          <td id="titlebar_buttons_td">
             <div class="titlebar_buttons">
               <div id="titlebar_close_button" onclick="cancel(false);">&#215</div>
             </div>
diff --git a/pd/nw/dialog_iemgui.html b/pd/nw/dialog_iemgui.html
index c176b7722..d40dbfa8f 100644
--- a/pd/nw/dialog_iemgui.html
+++ b/pd/nw/dialog_iemgui.html
@@ -11,7 +11,7 @@
           <td style="width: 100%;">
             <div id="titlebar_title">Iemgui Properties</div>
           </td>
-          <td>
+          <td id="titlebar_buttons_td">
             <div class="titlebar_buttons">
               <div id="titlebar_close_button" onclick="cancel(false);">&#215</div>
             </div>
diff --git a/pd/nw/dialog_prefs.html b/pd/nw/dialog_prefs.html
index d92a02242..e3611d53c 100644
--- a/pd/nw/dialog_prefs.html
+++ b/pd/nw/dialog_prefs.html
@@ -15,7 +15,7 @@ td {
           <td style="width: 100%;">
             <div id="titlebar_title">Pd-L2Ork Properties</div>
           </td>
-          <td>
+          <td id="titlebar_buttons_td">
             <div class="titlebar_buttons">
               <div id="titlebar_close_button" onclick="cancel(false);">&#215</div>
             </div>
-- 
GitLab