GitLab

The save abstraction operation must use the basename without the extension for
the object name. This regression was introduced in rev. 752294af, the present
commit corrects this while still preventing string overflows.

This gives what is to me smoother and more predictable snapping motion with
respect to the current mouse position.

For example-- imagine the grid cell size is 10 and the selected object under
the mouse already has its top left corner aligned with vertical grid line #2.

If I begin dragging that object to the left, within a single pixel of motion
it will snap to vertical grid line #1 which is 9 pixels away from the
object's current position.

With this commit, the user must drag the object cellsize / 2 pixels before it
snaps to a new position.

To me this seems smoother as it rounds to the nearest grid line rather than
to the grid line with the smallest coordinate value.

We also keep a partially transparent version of a grid for editmode. This
allows us to keep editmode visually distinct from runmode, even if snap-to-grid
isn't turned on.

If needed it's pretty easy to make the following changes:

* set the "big" cell size to something that isn't 100 (but I'm not sure how
  much control over the grid we actually want to give users-- e.g., setting
  the big cell to something for which the small cell isn't a factor
* allow snap-to-grid to be set independently for each canvas. (But again,
  what would be the use case for this?

also run for extended periods of time.

For some reason, GUI operations which run for extended periods of time
may cause the engine to crash with a SIGHUP error on Linux. Apparently
this is caused by the watchdog bailing out and taking the engine with
it. This affects the new print operation as well as the existing message
operation in the file menu, possibly also search index generation for
the help browser, and maybe some other operations that still need to be
identified.

The new gui-busy method lets the GUI set an internal flag in the engine
which makes the engine keep the watchdog happy while the GUI does its
thing, using the same mechanism that is already in place to ping the
watchdog when running GUI-less. To these ends, the GUI needs to invoke
"pd gui-busy 1" when starting the time-consuming operation, and "pd
gui-busy 0" when the operation is done.

Massaged the routine a bit to bring it more in line with what vanilla
currently has, and backported some recent changes in rev. 1f383be3 and
rev. ff9e52c6 from vanilla which are supposed to fix some bugs in
sys_domicrosleep.

* Used to have no margin on the right. Now it does and it matches the left side.

This reverts commit 5eb67db0, reversing
changes made to b363df22.

* Now the shift press is dynamic during the dragging and the grab is properly disengaged after letting go of the mouse, regardless if this happens over the object or outside it.

* gatom due to its reliance on the "click" legacy message lacks adequate information to allow for some of the advanced functionality of the iemgui numbox. This, coupled with other legacy behavior (e.g. having a min and max that does not apply to the values coming into its inlet) in my view make vanilla gatom a legacy object. This also makes a distinguishing factor between it and the iemgui numbox.

* Nonetheless, new features persist, such as drag and shift+drag that offers +-1 and +-0.01 increments respectively inside the number gatom, the ability to append to the symbol gatom text by shift+clicking onto it, and shift+delete deletes all the text at once inside the gatom symbol.

* Reenabled the mouseup event that was mysteriously disabled for an unknown amount of time. This made it difficult to report to the object mouse release event after it has been dragged and the mouse ended-up being positioned outside object's bounds.

* This now allows for very nice control over objects that are being grabbed.

* Mouse release sets doubleclick flag to -1 to differentiate itself from the regular mouse movement which also reports mouse press as 0.

* Allowed for glist_grab to be exclusive in respect to key presses and settable as such via the glist_grab call. See iemgui numbox for benefits of this implementation, described below.

* Completely reworked numbox logic with additional variables designed to improve code readability and disambiguate the x->x_gui.x_changed and x->x_gui.x_change.

* Rotated the order of event propagation to have glist_grab 1st and event bound objects second (e.g. key/keyname etc.). THIS IMPLEMENTATION SHOULD BE HEAVILY SCRUTINIZED TO MAKE SURE THERE ARE NO ADVERSE EFFECTS. Given the rapid release cycle I suggest adding it to the next release and then observing user feedback.

* The numbox now offers the following behavior:

1) click and drag and release (with or without shift which can be pressed at any time to toggle between fine +-0.01 and +-1 increments) which immediately changes the number value and outputs it. This kind of grab does not do exclusive keyboard grab and therefore allows keyboard to still propagate to other bound events.

2) click and immediately release enters the exclusive keyboard mode and makes the '>' appear to make the user aware of this. Here you can use arrows up/down with and without shift, press allowed keyboard keys (numbers, enter, delete, etc.) and edit the value accordingly. Pressing arrows always changes the last digit of the currently truncated number. Pressing enter commits the value and retains the focus for another 3 seconds unless user presses Esc or clicks outside the number box. If all the digits are erased the number implicity assumes 0.

3) clicking and immediately releasing without shift pressed to activate exclusive keyboard mode activates legacy/default behavior where entered text overwrites the existing (the cursor starts at the beginning and initially only has '>'). Doing the same with shift key puts the numbox in the append mode where one can continue adding to the previously committed number. This is even true if the displayed number is simply '+' or '-' due to it exceeding the number box width (not including decimals).

4) Values whenever committed are clipped to the object's min and max and reflected as such in the number object. If the object remains activated, the number is not clipped if it exceeds the object's length, but shows only last n visible digits. Upon removing focus (activation), it redraws from the beginning (if number of digits exceeds the width but does not exceed the min/max thresholds. Re-activating the object redraws it with the last digits visible.

* All glist_grab instances in externals should be taken care of and are, by default, not exclusive.

* Still TODO: checking if vanilla numbox is working ok. The rest of the objects shoould be unaffected.