From b3a1790ca7578dadf8103b4a3ac970303df180a3 Mon Sep 17 00:00:00 2001
From: Jonathan Wilkes <jon.w.wilkes@gmail.com>
Date: Tue, 20 Dec 2016 17:50:21 -0500
Subject: [PATCH] partial fix for midi prefs not getting saved under Windows
---
pd/nw/dialog_prefs.html | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/pd/nw/dialog_prefs.html b/pd/nw/dialog_prefs.html
index 313c43886..f7cf05698 100644
--- a/pd/nw/dialog_prefs.html
+++ b/pd/nw/dialog_prefs.html
@@ -345,7 +345,7 @@ function dev_change(elem) {
index = +(id.slice(-1)) - 1;
attrs = get_attr("pd-" + direction + type,
midi ? pd_midi_attrs : pd_audio_attrs);
- attrs[index] = midi ? +elem.value + 1 : elem.value;
+ attrs[index] = elem.value;
disable_unused_chans("in");
disable_unused_chans("out");
@@ -537,14 +537,14 @@ function populate_midi_devs(type, attrs) {
while (elem.firstChild) {
elem.removeChild(elem.firstChild);
}
- // make a dummy device named 'None' with value -1
+ // make a dummy device named 'None' with value 0
opt = document.createElement("option");
- opt.value = -1;
+ opt.value = 0;
opt.textContent = "None";
elem.appendChild(opt);
for (j = 0; j < dev_names.length; j++) {
opt = document.createElement("option");
- opt.value = j;
+ opt.value = j+1;
opt.textContent = dev_names[j];
elem.appendChild(opt);
}
@@ -685,6 +685,8 @@ function midi_prefs_callback(attrs) {
.style.setProperty("display", "none");
populate_midi_devs("in", attrs);
populate_midi_devs("out", attrs);
+ set_devs("midi_in", get_attr("pd-indevs", attrs));
+ set_devs("midi_out", get_attr("pd-outdevs", attrs));
}
pdgui.resize_window(pd_object_callback);
}
--
GitLab