From 6b13f22c28fb1906b47c95a7412310275e5ef941 Mon Sep 17 00:00:00 2001
From: Jonathan Wilkes <jon.w.wilkes@gmail.com>
Date: Sun, 18 Oct 2015 17:55:28 -0400
Subject: [PATCH] remove option to create a new array in an existing graph (but
patches which already have multiple arrays in a graph will continue to work)
---
pd/nw/dialog_canvas.html | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/pd/nw/dialog_canvas.html b/pd/nw/dialog_canvas.html
index 7561cc87f..eb2a8ba48 100644
--- a/pd/nw/dialog_canvas.html
+++ b/pd/nw/dialog_canvas.html
@@ -596,8 +596,12 @@ function populate_array_form(objects) {
opt.textContent = 'Array #' + (i+1);
arrays_select.appendChild(opt);
}
- // Hide checkbutton for existing graph if this isn't a new array dialog
- if (!new_array_dialog) {
+ // We're permanently hiding the checkbutton for creating a new array
+ // inside an existing graph. It's just a weird interface with very
+ // few benefits. However, patches that already have multiple arrays
+ // inside a graph will continue to work. (And if users really want
+ // this feature back it's easy to turn it back on.
+ if (!new_array_dialog || 1) { // to re-enable, remove the '|| 1'
document.getElementsByClassName('array_in_existing_graph')[0]
.classList.add('hidden');
}
--
GitLab