From adf329a81d3ba5137621811228baf1cfc1b04c02 Mon Sep 17 00:00:00 2001
From: Albert Graef <aggraef@gmail.com>
Date: Fri, 25 Sep 2020 01:06:07 +0200
Subject: [PATCH] Cosmetic change to 'declare' error handling.
If the declare object detects an unrecognized argument which isn't an
option symbol, it will print a weird-looking message complaining about
an empty flag. This commit makes it print a proper warning about an
unrecognized float argument instead.
---
pd/src/g_canvas.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/pd/src/g_canvas.c b/pd/src/g_canvas.c
index 9f60d2bdf..fa1447ff8 100644
--- a/pd/src/g_canvas.c
+++ b/pd/src/g_canvas.c
@@ -2237,7 +2237,14 @@ void canvas_declare(t_canvas *x, t_symbol *s, int argc, t_atom *argv)
canvas_stdlib(e, atom_getsymbolarg(i+1, argc, argv)->s_name);
i++;
}
- else post("declare: %s: unknown declaration", flag);
+ // ag: Handle the case of an unrecognized option argument (presumably
+ // a float).
+ else if (!*flag) {
+ post("declare: %g: unknown argument", atom_getfloatarg(i, argc, argv));
+ }
+ else {
+ post("declare: %s: unknown declaration", flag);
+ }
}
}
--
GitLab