GitLab

sys_expandpathelems: replacement for @pd_help should be the last element on the path, not the first.

These bugs were discovered via static code-analysis
https://scan.coverity.com/projects/pure-data-pure-data
(The CID numbers are the "Coverity IDs" used to identify the various bugs)

- Don't free binbuf within glist_readfrombinbuf (CID:74871)
- it must be deleted by the caller
- Initialize sockaddr_in (CID:74861,74862,74863,74866)
- Initialize indelay/outdelay (CID:74864,74865)
- Initialize device-arrays (CID:74853,74854,74855,74856)
- Closing unneeded sockets (CID:74827)
- Initialize sockaddr_in (CID:74860}
- Close file-descriptor if the soundfile is unparsable (CID:74822,74823)
- Close file-handle in cleanup (CID:74816)
- Call va_end() when handling variadic args (CID:74872)
- Added missing break (CID:74800)
- Prevent NULL-dereferences (CID:74792,74793)
- Size checks when copying into string buffers (CID:74844,74845,74846,74847,74849)
- Freeing no-more used storage (CID:74832)
- Fixed code block (CID:74806)
- Initialize sockaddr_in (CID:74860)
- Initialize array-values to 0 (CID:74867)
- Free allocated memory (CID:74813,74830)
- Removed allocation of unused memory
- Use pd_free() to free templates (CID:74814)
- template_free() does not free the entire structure (it misses the pd_new() part)
- initialize variable (CID:77865)
- Prevent NULL-pointer dererencing (CID:77864)
- Free heap-allocate binbuf after use (CID:74833)

very stupid kludge just to get the code to compile on Windows-- this needs to get fixed by a more complete backport of Pd Vanilla's s_path.c code

(manually ported)
*added @pd_help in addition to the existing @pd_extra that can be used for paths
*made pddplink capable of parsing @pd_extra and @pd_help
*updated cyclone help files to make advantage of the @pd_extra/@pd_help paths in order to reference global help file documentation

*backported vanilla patch http://sourceforge.net/p/pure-data/pure-data/ci/f535c339c99a74edb3920c2e630500df128b7d8f/

*Ported open_via_helppath from pd to fix inability to open help files when starting pd-l2ork from the doc/5.reference folder.

fixed regression where empty image box appeared on gop-ed parent in incorrect locations and/or it was not supposed to show up at all. Some refinements to the path detection/removal of debug output.

revamped path to support ~/, root paths, relative paths, as well as special tags like @pd_extra that expands to the location of the extra folder (other tags may be added later if necessary).

streamlined @pd_extra parsing for easier integration with other file open calls including externals. Added it to open_via_path

fixed noselect bug when line is selected and one clicks on a blank canvas which should also deselect selected line. also made pd_extrapath struct global as part of s_stuff.h so that ggee/image can use dynamic descriptors for retrieving of files (.e.g @pd_extra is translated to the pd's system-wide location of the extra/ folder)

working on new dialog windows
updates to 14.partialtracer and sigmund~

bug fixes