GitLab

These bugs were discovered via static code-analysis
https://scan.coverity.com/projects/pure-data-pure-data
(The CID numbers are the "Coverity IDs" used to identify the various bugs)

- Don't free binbuf within glist_readfrombinbuf (CID:74871)
- it must be deleted by the caller
- Initialize sockaddr_in (CID:74861,74862,74863,74866)
- Initialize indelay/outdelay (CID:74864,74865)
- Initialize device-arrays (CID:74853,74854,74855,74856)
- Closing unneeded sockets (CID:74827)
- Initialize sockaddr_in (CID:74860}
- Close file-descriptor if the soundfile is unparsable (CID:74822,74823)
- Close file-handle in cleanup (CID:74816)
- Call va_end() when handling variadic args (CID:74872)
- Added missing break (CID:74800)
- Prevent NULL-dereferences (CID:74792,74793)
- Size checks when copying into string buffers (CID:74844,74845,74846,74847,74849)
- Freeing no-more used storage (CID:74832)
- Fixed code block (CID:74806)
- Initialize sockaddr_in (CID:74860)
- Initialize array-values to 0 (CID:74867)
- Free allocated memory (CID:74813,74830)
- Removed allocation of unused memory
- Use pd_free() to free templates (CID:74814)
- template_free() does not free the entire structure (it misses the pd_new() part)
- initialize variable (CID:77865)
- Prevent NULL-pointer dererencing (CID:77864)
- Free heap-allocate binbuf after use (CID:74833)

*added debugging info

*m_pd.c debugging info
*improved dealing with scalar properties editor (making it persistent and alleviating errors of things being multiply defined)

reapplied Albert Graef's patch due to wrong patch being applied for the delayed unbind. Still have to work on ensuring that there are no memory leaks in unique cases where an object unbinds a different bindlist when receiving a message to do so on another (faust being an example of this).

fixed segfault due to delayed freeing of bindlists (necessary to prevent a segfault for dynamically changed sends/receives)

further improved the dynamic receive send/change to avoid potential crash when changing the next memeber of the same bindlist

Fixed crash when trying to do dynamic change of receives on iemgui objects (affects also all objects that allow for dynamic changing of the bindlist)

finished implementation and debugging of infinite undo. removed debugging statements from stderr, vastly improved pasting from external script.

removed rendundant memory hack and found potentially real and permanent fix to the double-entry bug (see g_canvas.c inside canvas_free() function). Many thanks to Krzysztof Czaja for his incredibly helpful hint!

added redundant memory remapping when creating new embedded canvases to avoid double-entry bug which has resurfaced since the introduction of the infinite undo.