GitLab

add mechanism that visually marks abstraction objects that are edited but unsaved, and all their ancestors

Hopefully a better fix for the paste and clipboard paste crashers. Also a bit of reformatting of the indentation inside one of the functions that did not have consistent indentation. LATER: figure out why the front-end is not disabling options like paste at start-up.

Added comment to provide an update on an issue documented in the comments

First checkpoint in implementing custom scrollbars and improving the scrollbar behavior. This is a WIP that requires nw.js 0.46.2.

Finished second stage of the scrollbar implementation and added scrolling with middle click. All scrollbars are now operational and to the best of my knowledge accurate. The only things remaining are: getscroll needs to be called on deselect to recalculate when the handles are erased on objects that have them (we should get rid of these and focus on bboxes instead), responding to maximizing and restoring, and addressing a weird bug where in 0.46.2 patches are saved with larger window sizes under certain conditions.

Reverted scrolling by grabbing due to problematic relationship between scrollBy and the zoom factor

Continuing work on the scrollbars. The only known thing now remaining is ensuring that the patch window is properly recorded when saving it (under certain conditions it spits out completely wrong values

Removed debug printouts

Finished the scrollbars. The only thing remaining is for someone who has a better understanding of the pd_canvas.js and how the events are captured, to refactor my registration of events that ensure scrollbars are clickable and the onresize event. Currently, they are embedded inside the pd_canvas.js under the body tag where you will find both onscroll and onresize events.

Overhaul of the new scrollbars to further improve their behavior, enable as perfect of a fit of the plots both in gop and on toplevel, and dynamic updating of the plots in toplevel when resized. Reworked dynamic event adding/removal for the scrollbars and removed onscroll from the html document and moved it into the pd_canvas.js. Still need to add a delay for the backend callback to update the scrollbars on the toplevel plot/array and thereby remove scrollbar flicker.

Finished implementing the scrollbar callback and addressed popup not appearing in the right place (likely due to upgrade to 0.46.2)

Added names of arrays to their toplevel subpatch window title. Multiple arrays are listed in the order they have been added.

Another reworking of scrollbars to and array sizing to capture all possible scenarios. Some refactoring to make use of the canvas_hasarray. Remaining known issues pertaining to the plots are:
*array toplevel windows are not restored in position they were saved
*last element on the plots is not clickable
*make bezier plot look like bezier (may need to leverage curve_path)

Additional commenting to make it easier to catch-up with the Wagnerian function dealing with the key input sent by the front-end. Disabled check that prevented exiting from the edit mode when creating a new object via a keyboard shortcut on a canvas in a non-edit mode. Upon releasing CTRL, the edit mode was not initiated.

Proper fix for the nlet highlighting. Now allows for loose aiming and always starts the patch cord at the center of the outlet. Inlets from which we currently cannot connect from are grey when highlighted, while ones you can initiate connection from are orange (both colors are themeable inside the css). Also, if trying to connect an impossible connection (signal to non-signal), when hovering over the non-signal inlet during the connection cycle, such an inlet will be also highlighted gray (grey? whatever...). Lastly, updated the highlighting animation--I am really not particularly interested in animation as it tends to slow down the interaction with the patch, so the animation is much shorter and more minimal. Potential value is leaving it as this to provide visibility of the nlet being highlighted when we are already over it with the cursor, which will otherwise occlude the nlet altogether. Another consideration with the currently committed highlight is that it is hollow inside which looks IMO distracting. Curved edges is also distracting since no other aspect of the UI (save for the customized data structures created by the user) is not curved.

Jonathan Wilkes authored Feb 09, 2018 and Albert Gräf committed Feb 10, 2018

Also fix a type mismatch in dropdown widget (g_text.c) and add
an error check in ALSA audio (s_audio_alsamm.c).

use canvas_getrootfor instead of glist_getcanvas, guarantee editor gets created when reloading abstractions

remove redundant call in g_mycanvas.c and filter repeated label updates if
the label hasn't changed as in Pd Vanilla

However, we still need to figure out if we want to supress gui_canvas_getscroll
when suppressing the scrollbars. Currently it still gets called, which will
adjust the viewport to make objects at negative indices visible. I think
instead we want to anchor the viewport to 0,0 at top left and supress those
calls to get a nice speedup in the GUI.

use "legacy_" prefix to guard against namespace collisions (plus self-documentation of the relevant classes)

add some rudimentary mouse tracking objects so that the questionable C code in the various mouse-related classes can be replaced with abstractions

This reverts commit 16973649, reversing
changes made to 15094e4c.

fix reference to "scope~" classname in g_editor, refactor pdgui.js to fit the new cyclone color methods

Intelligent patching mode 4 often just always prefers option A (outgoing
connections). But if the user actually wants option B (incoming connections),
he can't get it because option A was chosen. This is confusing, which is why
mode 4, while very useful if it works as intended, can be rather difficult to
use right now.

We therefore now take into account the status of the ctrl modifier, which
simply reverses our choice of option A or B, so that the user now has a way of
getting option B even if option A is preferred (and vice versa). If the ctrl
modifier isn't pressed, mode 4 works exactly as before, so this change is
fully backwards-compatible.

This change allows curly braces {} to be accepted as keypress events and entered into object and message boxes. It doesn't change the quoting rules for these characters, so [print] still escapes them with backslashes.