GitLab

The save abstraction operation must use the basename without the extension for
the object name. This regression was introduced in rev. 752294af, the present
commit corrects this while still preventing string overflows.

This gives what is to me smoother and more predictable snapping motion with
respect to the current mouse position.

For example-- imagine the grid cell size is 10 and the selected object under
the mouse already has its top left corner aligned with vertical grid line #2.

If I begin dragging that object to the left, within a single pixel of motion
it will snap to vertical grid line #1 which is 9 pixels away from the
object's current position.

With this commit, the user must drag the object cellsize / 2 pixels before it
snaps to a new position.

To me this seems smoother as it rounds to the nearest grid line rather than
to the grid line with the smallest coordinate value.

We also keep a partially transparent version of a grid for editmode. This
allows us to keep editmode visually distinct from runmode, even if snap-to-grid
isn't turned on.

If needed it's pretty easy to make the following changes:

* set the "big" cell size to something that isn't 100 (but I'm not sure how
  much control over the grid we actually want to give users-- e.g., setting
  the big cell to something for which the small cell isn't a factor
* allow snap-to-grid to be set independently for each canvas. (But again,
  what would be the use case for this?

This reverts commit 5eb67db0, reversing
changes made to b363df22.

* Reenabled the mouseup event that was mysteriously disabled for an unknown amount of time. This made it difficult to report to the object mouse release event after it has been dragged and the mouse ended-up being positioned outside object's bounds.

* This now allows for very nice control over objects that are being grabbed.

* Mouse release sets doubleclick flag to -1 to differentiate itself from the regular mouse movement which also reports mouse press as 0.

* Allowed for glist_grab to be exclusive in respect to key presses and settable as such via the glist_grab call. See iemgui numbox for benefits of this implementation, described below.

* Completely reworked numbox logic with additional variables designed to improve code readability and disambiguate the x->x_gui.x_changed and x->x_gui.x_change.

* Rotated the order of event propagation to have glist_grab 1st and event bound objects second (e.g. key/keyname etc.). THIS IMPLEMENTATION SHOULD BE HEAVILY SCRUTINIZED TO MAKE SURE THERE ARE NO ADVERSE EFFECTS. Given the rapid release cycle I suggest adding it to the next release and then observing user feedback.

* The numbox now offers the following behavior:

1) click and drag and release (with or without shift which can be pressed at any time to toggle between fine +-0.01 and +-1 increments) which immediately changes the number value and outputs it. This kind of grab does not do exclusive keyboard grab and therefore allows keyboard to still propagate to other bound events.

2) click and immediately release enters the exclusive keyboard mode and makes the '>' appear to make the user aware of this. Here you can use arrows up/down with and without shift, press allowed keyboard keys (numbers, enter, delete, etc.) and edit the value accordingly. Pressing arrows always changes the last digit of the currently truncated number. Pressing enter commits the value and retains the focus for another 3 seconds unless user presses Esc or clicks outside the number box. If all the digits are erased the number implicity assumes 0.

3) clicking and immediately releasing without shift pressed to activate exclusive keyboard mode activates legacy/default behavior where entered text overwrites the existing (the cursor starts at the beginning and initially only has '>'). Doing the same with shift key puts the numbox in the append mode where one can continue adding to the previously committed number. This is even true if the displayed number is simply '+' or '-' due to it exceeding the number box width (not including decimals).

4) Values whenever committed are clipped to the object's min and max and reflected as such in the number object. If the object remains activated, the number is not clipped if it exceeds the object's length, but shows only last n visible digits. Upon removing focus (activation), it redraws from the beginning (if number of digits exceeds the width but does not exceed the min/max thresholds. Re-activating the object redraws it with the last digits visible.

* All glist_grab instances in externals should be taken care of and are, by default, not exclusive.

* Still TODO: checking if vanilla numbox is working ok. The rest of the objects shoould be unaffected.

* Lots of debugging stuff lying around.

* A significant rewrite of the prior iemgui numbox behavior to capitalize on the exclusive grab opportunity.

* migrating to Linux for debugging

* Got rid of the problematic svg background which marginally worked on 0.14.7 but doesn't on 0.24.4

* Instead, using the existing msg border/background and adjusting its size dynamically

* The behavior remains identical to before (hide nlets, do not worry about readjusting patch cords)

* LATER: think about integrating patch cord and nlet adjustment to match vanilla behavior, consider further fine-tuning the text placement based on various zoom levels and fonts sizes (some still are a pixel off, this is true for also regular text objects), and finally implement this same approach for the regular text objects

Ivica Bukvic authored Sep 20, 2020 and Albert Gräf committed Sep 22, 2020

Broken implementation of grab focus improvement (to be migrated to linux because Windoze debugging is a joke)

Ivica Bukvic authored Sep 18, 2020 and Albert Gräf committed Sep 22, 2020

* Fun to know that canvas_key is called even when you are not inside a canvas...

Ivica Bukvic authored Sep 18, 2020 and Albert Gräf committed Sep 22, 2020

* This means an object has requested exclusive focus

Instead of casting a magic number to a pointer, which is a sure recipe
for disaster, provide a properly initialized dummy t_canvasenvironment*
pointing to static storage.

* This was caused by the improvement in the scrolling algorithm earlier this summer to throttle down getscroll calls invoked by arrays that resulted in CPU intensive redraws. As it turns out, the same also up until this patch prevented the following from working properly:

1. select text object and displace it by dragging using a mouse until it goes partially outside the canvas edge

2. the object is activated at a location before getscroll changes the viewport settings to ideally fit everything within the window

3. getscroll is called and everything is relocated except the activated box because its current implementation is oblivious to the changes in canvas positioning.

4. as a result the activated box does not match the actual object position.

* The new patch addresses this by introducing a synchronous scroll request that has no delays and executes immediately, thereby completing canvas relocation before the activated box is drawn. Due to its potential to be misused causing high CPU usage, this call is currently reserved only for this special case.

* LATER: consider ensuring that activated boxes are also relocated on getscroll, so that in the case of scripted changes to the viewport activated boxes remain in a correct place. Even so, this should not be seen as a workaround but as a feature that may prove useful in other contexts. So, the solution is to have both this patch and this other thing eventually implemented.

add an alert system that notifies the user of the existence of unsaved edited instances of the abstraction he is editing or about to edit

In one fell swoop, this solves all usability issues we have with the
Ctrl key we currently employ for that purpose, which interferes with all
our menu keybindings, and makes temporary run mode unusable on the Mac.

Make Ctrl+F work if the canvas is in edit mode. In this case,
canvas_key(), upon receiving the Ctrl keydown event from the Ctrl+F
shortcut, temporarily switches to run mode, but never gets the
corresponding keyup event which goes to the findbox, so temporary run
mode remains in effect when the findbox opens.

This shouldn't actually be much of a problem, but the real trouble is
that while canvas_key() informs the GUI about the change to run mode, it
doesn't update the state of the canvas-local gl_edit variable
accordingly. So when dofind() switches on edit mode later, the engine
still thinks that it's in edit mode and thus doesn't trigger the
necessary update.

The easy fix is to just update gl_edit in canvas_key() when edit mode is
temporarily disabled.

This gets rid of some race conditions in the find operation, by ensuring
that edit mode is only updated *after* mapping a subpatch window.

This bug manifested itself when searching for objects in subpatches
which are not visible at the time the find operation gets invoked. In
this case, on the GUI side we both have to create the subpatch window
and put it in edit mode. In the previous implementation these two
operations would be executed separately and asynchronously. The end
result was that usually the latter operation setting the edit mode in
the GUI would win out, and the edit mode would later get overwritten
again when the window was created.

We fixed that race condition by ensuring that the engine is queried for
its current edit mode status after creating a canvas window. The engine
replies with a call to gui_canvas_set_editmode() in the GUI and thus the
edit mode in the GUI now properly reflects the status in the engine
after a window is mapped.

TL;DR: This fix should now make sure that edit mode on the GUI side
reflects that of the engine at all times.

This makes Ctrl+F work again, by making sure that edit mode is set
correctly in the GUI even if glob_ctrl is set (because the Ctrl key up
event goes to the find box and is thus is never received by the canvas).

Albert Gräf authored Sep 01, 2020 and Albert Gräf committed Sep 09, 2020

This is useful, in particular, to print out pointer values with the
%zx specifier, since it prevents the annoying format warnings when
using %zx with t_int.

Ivica Bukvic authored Aug 31, 2020 and Albert Gräf committed Sep 06, 2020

* Created new and hopefully improved dialogs that should work on all
  three OSs. These include improved margins, optimal sizes that account
  for OS-specific idiosyncrasies, use of non-native toplevel window
  titlebars that cause bunch of issues (e.g. ability to maximize a
  dialog window since nw.js, at least in the earlier versions, has
  spotty support for disabling those), fixed window sizes with minimal
  scrollbars where appropriate, proper spacing between items, better
  positioning of the checkbox and radio buttons, etc.

* Enabled CTRL+W for the search dialog.

* Improved and consistent find bar appearance on all windows (console,
  patch, search).

* Refined activated box to match different zoom levels and font
  sizes. Small discrepancies still exist when using both custom fonts
  and zoom levels, but these are now no more than pixel off, whereas
  before it was all over the place.

* Made sure that patch windows on all OSs are exactly the same size,
  even when using custom zoom levels and fonts.

* Replaced the use of the legacy font menu with the native sub-menu and
  adjusted its behavior accordingly, including updating its values at
  patch open (the same method may prove useful in dealing with the
  undo/redo and other options not being registered properly because they
  may be running before the menu has been created).

* Refined the scrollbar behavior by providing a grab cursor when
  hovering and clicking on them. Also added dynamic updates to scrollbar
  colors (normal, hover, and click).

* Epic hack for making message boxes consistent size when activated.

* Made redrect on a GOP subpatch appear and disappear intelligently when
  dealing with subpatches populated exclusively with scalars. For
  instance, creating an empty object does not create a redrect yet
  because the user may be instantiating another instance of a
  scalar (e.g. a pony). However, once a non-data object has been created
  that wants to be displayed on the parent window inside GOP of the
  subpatch it is a part of, it toggles on. Similarly, once every
  non-scalar object has been deleted, the redrect disappears. There is
  still a lingering question why would one want to do this, but hey, who
  am I to judge?

* Fixed problem where a non-GOP text object got diagonal and y resize
  arrows that triggered consistency check.

* Fixed consistency check where resizing a GOP on the parent window
  using bottom-right corner cursor hotspots, triggered an error when the
  subpatch is also open. Now, everything resizes as it should
  concurrently, regardless of whether this is done on the subpatch or
  the parent window. As a bonus, the properties window reflects changed
  values regardless how they are being changed.

* Better iemgui number2 text offset across different font sizes and zoom
  levels.

* I think that is about it, although I may have missed something...

add mechanism that visually marks abstraction objects that are edited but unsaved, and all their ancestors

get rid of some compiler warnings introduced by the two new features (incompatible pointer type and implicit declaration)

add [abdefs] object (methods: get, instances, del, clean) with an interactive dialog, add new element type for dialog_external