From c7ba3db005a01b301cb9c7cd82cd9ad4e43a0b8b Mon Sep 17 00:00:00 2001 From: Jonathan Wilkes <jon.w.wilkes@gmail.com> Date: Wed, 9 Mar 2016 20:35:20 -0500 Subject: [PATCH] fix bug with unused and *undefined* variable index Note: this slipped through the cracks because GNU's string.h apparently exposes an object named "index". Compiling under mingw revealed the bug. --- pd/nw/pdgui.js | 2 +- pd/src/g_vumeter.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/pd/nw/pdgui.js b/pd/nw/pdgui.js index deb31f4c9..02dc053d8 100644 --- a/pd/nw/pdgui.js +++ b/pd/nw/pdgui.js @@ -2176,7 +2176,7 @@ function gui_vumeter_erase_text(cid, tag, i) { t.parentNode.removeChild(t); } -function gui_vumeter_create_steps(cid,tag,x_color,p1,p2,p3,p4,width,index,basex,basey,i) { +function gui_vumeter_create_steps(cid,tag,x_color,p1,p2,p3,p4,width,basex,basey,i) { var g = get_gobj(cid, tag), l; l = create_item(cid, "line", { diff --git a/pd/src/g_vumeter.c b/pd/src/g_vumeter.c index 8e46cae5b..154154d6d 100644 --- a/pd/src/g_vumeter.c +++ b/pd/src/g_vumeter.c @@ -152,9 +152,9 @@ static void vu_draw_new(t_vu *x, t_glist *glist) led_col = iemgui_vu_col[i]; if (i<=IEM_VU_STEPS) { - gui_vmess("gui_vumeter_create_steps", "xxxiiiiiiiii", + gui_vmess("gui_vumeter_create_steps", "xxxiiiiiiii", canvas, x, iemgui_color_hex[led_col], quad1+1, - yyy+2, quad3, yyy+2, x->x_led_size, index, x1, y1, i); + yyy+2, quad3, yyy+2, x->x_led_size, x1, y1, i); } } gui_vmess("gui_vumeter_draw_rect", "xxxiiiiii", -- GitLab