purr-data issueshttps://git.purrdata.net/jwilkes/purr-data/-/issues2020-09-11T21:28:56Zhttps://git.purrdata.net/jwilkes/purr-data/-/issues/682Auto-complete feature in Purr Data2020-09-11T21:28:56Z60-hzAuto-complete feature in Purr DataPurr Data still miss one great feature which is auto-complete for objects boxes.Purr Data still miss one great feature which is auto-complete for objects boxes.https://git.purrdata.net/jwilkes/purr-data/-/issues/669nw.js 0.46/0.47 issues2020-09-06T08:11:55ZAlbert Gräfnw.js 0.46/0.47 issuesDocument regressions with respect to the latest nw.js versions here.Document regressions with respect to the latest nw.js versions here.https://git.purrdata.net/jwilkes/purr-data/-/issues/681Fallback mechanism for missing translations2020-09-03T22:54:02ZAlbert GräfFallback mechanism for missing translationsWe need a fallback mechanism for missing translations in foreign languages which defaults to the en locale if some localized string cannot be found. Cf. https://git.purrdata.net/jwilkes/purr-data/-/merge_requests/500#note_7838.We need a fallback mechanism for missing translations in foreign languages which defaults to the en locale if some localized string cannot be found. Cf. https://git.purrdata.net/jwilkes/purr-data/-/merge_requests/500#note_7838.https://git.purrdata.net/jwilkes/purr-data/-/issues/680pddp link does not always revert to its instantiated format after editing2020-09-02T19:38:02ZIvica Bukvicpddp link does not always revert to its instantiated format after editingIn the about patch, in edit mode, click on a pddp/link, and it will be activated and become editable. If one clicks outside any other object, it will be properly deselected and re-instantiate in its clickable (non-activated) format. Howe...In the about patch, in edit mode, click on a pddp/link, and it will be activated and become editable. If one clicks outside any other object, it will be properly deselected and re-instantiate in its clickable (non-activated) format. However, if while pddp/link is activated, if you click on something else and immediately select it, it will become deselected but its content will remain as if it is in activated mode.https://git.purrdata.net/jwilkes/purr-data/-/issues/658Legacy tcl command in g_canvas.c tripped by about patch2020-09-02T09:16:46ZAlbert GräfLegacy tcl command in g_canvas.c tripped by about patchUnfortunately, I can't reproduce this reliably, but while testing Ico's branch for "old" (pre 0.46) nw.js regressions, I sometimes got a message like this in the console when opening the about patch via Help => About Pd-L2ork, so I thoug...Unfortunately, I can't reproduce this reliably, but while testing Ico's branch for "old" (pre 0.46) nw.js regressions, I sometimes got a message like this in the console when opening the about patch via Help => About Pd-L2ork, so I thought that I might just as well report it:
~~~
legacy tcl command at 1815 of g_canvas.c: pdtk_select_all_gop_widgets .x56290a4297b0 56290a392610 1
~~~
The line is actually at https://git.purrdata.net/jwilkes/purr-data/-/blob/master/pd/src/g_canvas.c#L1772 in the current master branch (but at line 1815 in Ico's branch), in the `glist_redrawall` function. It reads (I've included the two comment lines above for context):
~~~c
/* Haven't tested scalars inside gop yet, but we
probably need a gui_vmess here */
sys_vgui("pdtk_select_all_gop_widgets .x%lx %lx %d\n",
glist_getcanvas(gl), gl, 1);
~~~
This code is pretty ancient (rev. 4717bd585 "Jonathan's clean-up of the g_canvas.c" submitted by Ico Sat Mar 8 22:32:28 2014 -0500 according to git blame), so this seems to be a leftover from the olden pd-l2ork 1.x days.
I'm not sure how this code gets tripped or why, as I said I couldn't really pin this down because I can only reproduce it by accident so far. It *might* be tripped by Ico's changes (if so, then maybe by rev. b16cbaed3cb40d232849553b200fdbfa70e7f9e2?), but I'm not sure at all about that either. But I'm pretty well sure that we don't want this code to be there in 2020, waiting for its chance to be executed. ;-)
@jwilkes Maybe you can figure out what's up with this legacy tcl call and why it's still there. Maybe we can just comment it out, so that it doesn't by accident rear its head?Jonathan WilkesJonathan Wilkeshttps://git.purrdata.net/jwilkes/purr-data/-/issues/678Data dialog issues2020-08-28T04:37:25ZIvica BukvicData dialog issuesData dialog should auto-update when the data structure is manipulated directly. This includes vars and the vector.
The second issue is not entirely clear to me. When editing vector data, are we allowed to add new data or only edit exist...Data dialog should auto-update when the data structure is manipulated directly. This includes vars and the vector.
The second issue is not entirely clear to me. When editing vector data, are we allowed to add new data or only edit existing? If we should be able to add new data, then this is impossible since enter is mapped to the dialog's OK button and this should be fixed. A common way of addressing this is (e.g. via social media platforms) when trying to send a multiline comment, one presses shift+return(or shift+enter) which gives them a newline without sending the message.https://git.purrdata.net/jwilkes/purr-data/-/issues/596Multiline comments have not been ported from 1.x branch2020-08-27T19:34:48ZIvica BukvicMultiline comments have not been ported from 1.x branchhttps://git.purrdata.net/jwilkes/purr-data/-/issues/677Adjusting font size back and forth at a zoom level than default (100%) distor...2020-08-27T05:04:25ZIvica BukvicAdjusting font size back and forth at a zoom level than default (100%) distorts location of objects in gop-enabled subpatches and toplevelsResized GOP windows suddenly lose visibility of its contents (which is expected if it is a subpatch whose font is tied to the parent patch). However, resetting font size does not restore original position. Sometimes objects remain stale ...Resized GOP windows suddenly lose visibility of its contents (which is expected if it is a subpatch whose font is tied to the parent patch). However, resetting font size does not restore original position. Sometimes objects remain stale outside the GOP window and one cannot get rid of them.https://git.purrdata.net/jwilkes/purr-data/-/issues/676Subpatch data scalar toplevel window should rescale its scalars when the wind...2020-08-27T05:02:23ZIvica BukvicSubpatch data scalar toplevel window should rescale its scalars when the window is rescaledOpen disis_wiimote-help.pd and the subpatch for either blobs or joystick and resize it and note that the data scalar does note rescale accordingly.Open disis_wiimote-help.pd and the subpatch for either blobs or joystick and resize it and note that the data scalar does note rescale accordingly.https://git.purrdata.net/jwilkes/purr-data/-/issues/647Remaining issues for the GOP/toplevel Plots2020-08-27T05:01:24ZIvica BukvicRemaining issues for the GOP/toplevel Plots* last element on the plots is not clickable
* make bezier plot look like bezier (may need to leverage curve_path)
* @jwilkes it looks like the elements not being clickable may be linked to the overall miscalculation of the scalar hitbox...* last element on the plots is not clickable
* make bezier plot look like bezier (may need to leverage curve_path)
* @jwilkes it looks like the elements not being clickable may be linked to the overall miscalculation of the scalar hitbox. See disis_wiimote-help.pd patch and open the subpatch with the 4 blobs (found on the right). Selecting each blob creates a much larger selection box than it should and it is larger the more the object is to the right and down. If you position the object the top left corner of the patch screen, its bbox is near perfect. This is clearly a miscalculation/regression from the port to nw.js as this was not an issue before.
I also edited this issue title since it affects all nw.js versions.Ivica BukvicIvica Bukvichttps://git.purrdata.net/jwilkes/purr-data/-/issues/675Selection boxes of data scalars in the GOP-enabled subpatch window are way of...2020-08-27T05:01:23ZIvica BukvicSelection boxes of data scalars in the GOP-enabled subpatch window are way off and correlate to the distance from the top-left corner of the patch windowOpen disis_wiimote-help.pd and open the subpatch with blobs, go to edit mode and try selecting and moving the 4 blobs. This may be related to #647Open disis_wiimote-help.pd and open the subpatch with blobs, go to edit mode and try selecting and moving the 4 blobs. This may be related to #647https://git.purrdata.net/jwilkes/purr-data/-/issues/670key missing in [key] and [keyname]2020-08-19T05:05:15Z60-hzkey missing in [key] and [keyname]The following key reports have problems with [keyname] object (same with [key]):
Space: nothing return
Return: only keydown/keyup but no name with [keyname]
cmd: nothing return
Caps_lock: nothing return
Shift_L: only "Shift" (no info Sh...The following key reports have problems with [keyname] object (same with [key]):
Space: nothing return
Return: only keydown/keyup but no name with [keyname]
cmd: nothing return
Caps_lock: nothing return
Shift_L: only "Shift" (no info Shift_L / Shift_R)
Super_L: nothing returnhttps://git.purrdata.net/jwilkes/purr-data/-/issues/662[list store] not optimal for building gigantic messages2020-07-26T19:30:06ZJonathan Wilkes[list store] not optimal for building gigantic messagesIf you try to accumulate a large list with [list store], reallocation time becomes a major factor on Windows.
Can easily improve realloc times by overallocating using a simple doubling algorithm.
There's already a related "quick-and-di...If you try to accumulate a large list with [list store], reallocation time becomes a major factor on Windows.
Can easily improve realloc times by overallocating using a simple doubling algorithm.
There's already a related "quick-and-dirty" algorithm like that in unpost_printhook to fill in for C++ iostream from matju's original C++ implementation. So we probably want to put an interface in m_memory.c for general use.
However, we'd need to be careful to document this interface as inappropriate for realtime computation. While it can vastly improve average performance it doesn't guarantee worst-case performance. (And in fact better average perf can *hide* worst-case perf from the user, which is a strange but very real usability problem in soft realtime environments like this.)
In fact, we may consider adding something like [list storeupto 100] to initialize max size to 100 and error out above that. This would avoid realloc altogether and *could* be realtime safe if we handle gpointers efficiently.Jonathan WilkesJonathan Wilkeshttps://git.purrdata.net/jwilkes/purr-data/-/issues/657make selection from clicking "error" link in pd more obvious2020-07-07T07:15:01ZJonathan Wilkesmake selection from clicking "error" link in pd more obviousWhen the user clicks the "error" hyperlink in the Pd window, if the relevant object is in the current top level window then putting a selection around it is too subtle.
Especially for an iemgui with a dark background color, the border h...When the user clicks the "error" hyperlink in the Pd window, if the relevant object is in the current top level window then putting a selection around it is too subtle.
Especially for an iemgui with a dark background color, the border highlight is barely even noticeable.
Two options:
* use a CSS animation to draw the user's eye
* put the cord inspector over there (and perhaps fill it with the error message)https://git.purrdata.net/jwilkes/purr-data/-/issues/655Scrollbar viewport slightly off2020-07-06T05:57:17ZAlbert GräfScrollbar viewport slightly offThis is just something I noticed while testing Ico's nw.js 0.4x branch, but I can reproduce this also with Purr Data 2.10.1 and 2.11.0 (using nw.js 0.24.4), so it's not related to the latest work in any way and has been with us for a lit...This is just something I noticed while testing Ico's nw.js 0.4x branch, but I can reproduce this also with Purr Data 2.10.1 and 2.11.0 (using nw.js 0.24.4), so it's not related to the latest work in any way and has been with us for a little while. Tested on Linux (Manjaro), but I suspect that it's the same across all supported platforms. It's just a (very) minor cosmetic issue, just something I noticed, so I thought I'd report it, so that it might be addressed in a future release.
It appears that the viewport calculation for the scrollbars is slightly off, so that it's possible to have the patch window contents partially obscured, but no scrollbar visible yet. E.g., in the screenshot below you can see that both the right edge of the array `wave` and the bottom edge of the `tabwrite~` object have become invisible (by reducing the window size), yet there are no scrollbars (yet). (Of course, the scrollbars do appear if I continue to make the window smaller.)
![viewport](/uploads/98e96b02c808500f656ca92970a2b3c0/viewport.png)
Here's the little patch I used in the screenshot, for reproducibility: [subtractive.pd](/uploads/ab00df534bdaccdc08c5cb2f283c62bb/subtractive.pd)https://git.purrdata.net/jwilkes/purr-data/-/issues/656[symbol 123( needs a warning2020-07-05T17:52:20ZJonathan Wilkes[symbol 123( needs a warningWhen the user types a float payload for a symbol message into the message box, it should give a warning:
[symbol 123( <-- warning: this is silently converted to empty symbol
We should also check the code to make sure it's well-defined ...When the user types a float payload for a symbol message into the message box, it should give a warning:
[symbol 123( <-- warning: this is silently converted to empty symbol
We should also check the code to make sure it's well-defined c that does the conversion, and not just setting one union field and accidentally reading from the otherhttps://git.purrdata.net/jwilkes/purr-data/-/issues/653[cputime] doesn't work properly when compiled with emscripten2020-06-25T00:17:55ZZack Lee[cputime] doesn't work properly when compiled with emscriptenThe [cputime] object doesn't work properly and always outputs 0 when compiled with emscripten.
The issue is caused by the `times()` function from `sys/times.h` not currently being supported/implemented in emscripten.
Here's the relevan...The [cputime] object doesn't work properly and always outputs 0 when compiled with emscripten.
The issue is caused by the `times()` function from `sys/times.h` not currently being supported/implemented in emscripten.
Here's the relevant post: https://github.com/emscripten-core/emscripten/issues/11491
This could potentially be fixed by using JavaScript to calculate the CPU time when built with emscripten.https://git.purrdata.net/jwilkes/purr-data/-/issues/652gui_textarea uses both "top" and "transform" property2020-06-22T02:05:02ZJonathan Wilkesgui_textarea uses both "top" and "transform" propertyRecent improvements to gui_textarea added a "transform" to translateY by some pixels. This extra property is not needed-- the value should just be calculated into the "top" property above it.Recent improvements to gui_textarea added a "transform" to translateY by some pixels. This extra property is not needed-- the value should just be calculated into the "top" property above it.Ivica BukvicIvica Bukvichttps://git.purrdata.net/jwilkes/purr-data/-/issues/651add element parameter for gui.append method2020-06-21T17:01:17ZJonathan Wilkesadd element parameter for gui.append methodThe user might want to have a reference to the parent they're appending to. So the function sig should be something like `function(frag, e, window, nw_win)`The user might want to have a reference to the parent they're appending to. So the function sig should be something like `function(frag, e, window, nw_win)`Jonathan WilkesJonathan Wilkeshttps://git.purrdata.net/jwilkes/purr-data/-/issues/650iemgui updates from Pd 0.46/0.472020-06-21T00:13:08ZAlexandre Porresiemgui updates from Pd 0.46/0.47Hi, as of Pd 0.46, there has been a few changes to iemguis, which now don't clip values anymore (nbx still does though). Moreover, the color scheme changed for [cnv] and [vu]. Finally, as of Pd 0.47 you can now set colors with hexnotatio...Hi, as of Pd 0.46, there has been a few changes to iemguis, which now don't clip values anymore (nbx still does though). Moreover, the color scheme changed for [cnv] and [vu]. Finally, as of Pd 0.47 you can now set colors with hexnotation.
You can check the help files of iemguis for more details in the newly released Pd Vanilla 0.51