Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • P purr-data
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 363
    • Issues 363
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 54
    • Merge requests 54
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Jonathan Wilkes
  • purr-data
  • Issues
  • #369

Closed
Open
Created Aug 22, 2017 by Jonathan Wilkes@jwilkesOwner

use static declarations in external libraries

All externals need to have their functions and global variables declared as static. Otherwise namespace pollution across translation units will occur.

All externals currently do not.

For simple externals, this can just be a matter of adding the static keyword where necessary. (Excluding the *_setup function, of course.)

For more complex libraries (ones that use their own shared libs, have their own headers, crazy nested makefiles) this will require more caution/testing.

Assignee
Assign to
Time tracking