purr-data merge requestshttps://git.purrdata.net/jwilkes/purr-data/-/merge_requests2022-08-08T01:19:15Zhttps://git.purrdata.net/jwilkes/purr-data/-/merge_requests/833Update the installations instructions for the new JGU repositories.2022-08-08T01:19:15ZAlbert GräfUpdate the installations instructions for the new JGU repositories.Hi Jonathan, as promised, I updated all my own docs now so that they point to the new purr-data-jgu repositories. We still need to update the information in the toplevel README.md, though. This MR takes care of that.Hi Jonathan, as promised, I updated all my own docs now so that they point to the new purr-data-jgu repositories. We still need to update the information in the toplevel README.md, though. This MR takes care of that.Jonathan WilkesJonathan Wilkeshttps://git.purrdata.net/jwilkes/purr-data/-/merge_requests/590Gop redrect and scalars regression fix2020-10-09T20:29:10ZIvica BukvicGop redrect and scalars regression fixIMPORTANT! Please note this is applied on top of the !587 to ensure there are no further regressions and is probably best applied after that merge request is merged.
* It is supposed to toggle on and off depending on whether the subpatc...IMPORTANT! Please note this is applied on top of the !587 to ensure there are no further regressions and is probably best applied after that merge request is merged.
* It is supposed to toggle on and off depending on whether the subpatch has scalars only in it. It does this by also intelligently accounting for temporary text objects that are created and need to be filled by the scalar name before they are converted into a scalar class.
* There is one condition the original implementation failed to account for: creating a new text_object in an empty canvas which erroneously still resulted in the assumption that the subpatch consisted of only scalars.
* This patch fixes this special case.
* To test: create an empty subpatch and enable GOP, inside the subpatch create an empty object which will erase GOP until you make that object something concrete (e.g. print). With this merge request applied, the GOP redrect will in this case never disappear (and it shouldn't). It will continue to disappear in situations where there are only scalars (as per original merge request that was merged a while ago).Jonathan WilkesJonathan Wilkeshttps://git.purrdata.net/jwilkes/purr-data/-/merge_requests/588Fine-tuned the dropdown dialog window size2020-10-12T21:10:19ZIvica BukvicFine-tuned the dropdown dialog window size* Used to have no margin on the right. Now it does and it matches the left side.* Used to have no margin on the right. Now it does and it matches the left side.2.15.1https://git.purrdata.net/jwilkes/purr-data/-/merge_requests/577Introduced new activated msg border drawing approach2020-10-07T00:05:07ZIvica BukvicIntroduced new activated msg border drawing approach* Got rid of the problematic svg background which marginally worked on 0.14.7 but doesn't on 0.24.4 (e.g. create a msg object, deactivate it by clicking anywhere on the canvas, and then zoom in a level or two and notice an additional ver...* Got rid of the problematic svg background which marginally worked on 0.14.7 but doesn't on 0.24.4 (e.g. create a msg object, deactivate it by clicking anywhere on the canvas, and then zoom in a level or two and notice an additional vertical line; also, note that the flags on the right are transparent and not perfectly aligned).
* Instead, using the existing msg border/background and adjusting its size dynamically
* The behavior remains identical to before (hide nlets, do not worry about readjusting patch cords)
* LATER: think about integrating patch cord and nlet adjustment to match vanilla behavior, and implement this same approach for the regular text objects2.15.1https://git.purrdata.net/jwilkes/purr-data/-/merge_requests/573WIP: Improved caret positioning inside an editable msg object2020-09-30T00:16:32ZIvica BukvicWIP: Improved caret positioning inside an editable msg object* When there is no text inside the msg (e.g. when creating a new msg object), the editable caret is higher than when there is text inside the msg object.
* This fix using eventListener modifies the -webkit-padding before and after the p...* When there is no text inside the msg (e.g. when creating a new msg object), the editable caret is higher than when there is text inside the msg object.
* This fix using eventListener modifies the -webkit-padding before and after the paragraph to ensure the caret maintains the same position.
* LATER: check if newer nw.js versions still have this problem as it does look like a nw.js bug (nothing on our end changes between the paragraph text being empty and non-empty).Ivica BukvicIvica Bukvichttps://git.purrdata.net/jwilkes/purr-data/-/merge_requests/571Cosmetic change to 'declare' error handling.2020-09-30T21:43:02ZAlbert GräfCosmetic change to 'declare' error handling.If the declare object detects an unrecognized argument which isn't an option symbol, it will print a weird-looking message complaining about an empty flag. This commit makes it print a proper warning about an unrecognized float argument ...If the declare object detects an unrecognized argument which isn't an option symbol, it will print a weird-looking message complaining about an empty flag. This commit makes it print a proper warning about an unrecognized float argument instead.Jonathan WilkesJonathan Wilkeshttps://git.purrdata.net/jwilkes/purr-data/-/merge_requests/570WIP: footils knob overhaul2020-10-02T00:52:48ZIvica BukvicWIP: footils knob overhaulComplete overhaul of the knob object to ensure it draws and behaves correctly. Everything should work with one notable exception: the logarithmic displacement is permanently disabled as it never quite worked the way it should.
**Please ...Complete overhaul of the knob object to ensure it draws and behaves correctly. Everything should work with one notable exception: the logarithmic displacement is permanently disabled as it never quite worked the way it should.
**Please note this merge request does not include any of the improvements that are to be introduced in the !544, so the !544 will very likely depend on this one moving forward.**Ivica BukvicIvica Bukvichttps://git.purrdata.net/jwilkes/purr-data/-/merge_requests/569Enabled visual feedback when clicking on the empty symbol gatom to edit its v...2020-10-06T19:10:27ZIvica BukvicEnabled visual feedback when clicking on the empty symbol gatom to edit its value* Before, empty symbol gatom had no feedback when being clicked on and one had to start typing trusting that the object is indeed properly activated.
* Now, the object draws ... as soon as an empty (and only empty) symbol gatom is selec...* Before, empty symbol gatom had no feedback when being clicked on and one had to start typing trusting that the object is indeed properly activated.
* Now, the object draws ... as soon as an empty (and only empty) symbol gatom is selected, so that it has text to highlight thereby letting the user know that the object is ready to receive their input. In case the symbol gatom already has content, then that content gets highlighted which serves the same purpose.
* This does not affect the float gatom.2.15.1Ivica BukvicIvica Bukvichttps://git.purrdata.net/jwilkes/purr-data/-/merge_requests/568Disabled excessive coll legacy call warnings2020-09-30T21:43:06ZIvica BukvicDisabled excessive coll legacy call warningsIvica BukvicIvica Bukvichttps://git.purrdata.net/jwilkes/purr-data/-/merge_requests/563Fixed asynchronous getscroll and activate regression2020-09-30T21:43:07ZIvica BukvicFixed asynchronous getscroll and activate regression* This was caused by the improvement in the scrolling algorithm earlier this summer to throttle down getscroll calls invoked by arrays that resulted in CPU intensive redraws. As it turns out, the same also up until this patch prevented t...* This was caused by the improvement in the scrolling algorithm earlier this summer to throttle down getscroll calls invoked by arrays that resulted in CPU intensive redraws. As it turns out, the same also up until this patch prevented the following from working properly:
1. select text object and displace it by dragging using a mouse until it goes partially outside the canvas edge
2. the object is activated at a location before getscroll changes the viewport settings to ideally fit everything within the window
3. getscroll is called and everything is relocated except the activated box because its current implementation is oblivious to the changes in canvas positioning.
4. as a result the activated box does not match the actual object position.
* The new patch addresses this by introducing a synchronous scroll request that has no delays and executes immediately, thereby completing canvas relocation before the activated box is drawn. Due to its potential to be misused causing high CPU usage, this call is currently reserved only for this special case.
* LATER: consider ensuring that activated boxes are also relocated on getscroll, so that in the case of scripted changes to the viewport activated boxes remain in a correct place. Even so, this should not be seen as a workaround but as a feature that may prove useful in other contexts. So, the solution is to have both this patch and this other thing eventually implemented.Ivica BukvicIvica Bukvichttps://git.purrdata.net/jwilkes/purr-data/-/merge_requests/555Adjusted scale on the vu meter to match position of vanilla pd2020-09-17T19:45:45ZIvica BukvicAdjusted scale on the vu meter to match position of vanilla pdhttps://git.purrdata.net/jwilkes/purr-data/-/merge_requests/554Improvements to iemgui numbox (drawstyle, font sizing and dialog) (was: now c...2020-09-30T21:43:02ZIvica BukvicImprovements to iemgui numbox (drawstyle, font sizing and dialog) (was: now checks & autoadjusts height based on font size)* drawstyle ported from 1.x (formerly known as hide_frame option)
* font sizing applies only to the label, not the number value
* number value is automatically sized based on the numbox height
* improved dialog to accommodate the new ...* drawstyle ported from 1.x (formerly known as hide_frame option)
* font sizing applies only to the label, not the number value
* number value is automatically sized based on the numbox height
* improved dialog to accommodate the new option
* fixed sizing inconsistency when changing fonts (fonts only apply to the label, this was the case even before this patch), which is not how vanilla behaves but nonetheless is now a preferred way of operating, so when calculating the numbox width, we make sure it only uses the default font (DejaVuSans)Ivica BukvicIvica Bukvichttps://git.purrdata.net/jwilkes/purr-data/-/merge_requests/529Refined save dialog positioning2020-09-13T02:54:57ZIvica BukvicRefined save dialog positioningIvica BukvicIvica Bukvic