purr-data merge requestshttps://git.purrdata.net/jwilkes/purr-data/-/merge_requests2017-02-08T02:52:42Zhttps://git.purrdata.net/jwilkes/purr-data/-/merge_requests/73Enable -legacy behavior of bendin (fixes #245).2017-02-08T02:52:42ZAlbert GräfEnable -legacy behavior of bendin (fixes #245).As discussed in #245. -legacy reverts bendin to vanilla bug compatibility. Tested against vanilla (Pd 0.47.1), works as advertized.As discussed in #245. -legacy reverts bendin to vanilla bug compatibility. Tested against vanilla (Pd 0.47.1), works as advertized.https://git.purrdata.net/jwilkes/purr-data/-/merge_requests/74Now that 2.0 is out, update debuild to a release-based versioning scheme.2017-02-09T23:56:36ZAlbert GräfNow that 2.0 is out, update debuild to a release-based versioning scheme.https://git.purrdata.net/jwilkes/purr-data/-/merge_requests/75Defunkify Windows pathnames in the add-recent-file FUDI message. Fixes #247.2017-02-11T22:42:23ZAlbert GräfDefunkify Windows pathnames in the add-recent-file FUDI message. Fixes #247.https://git.purrdata.net/jwilkes/purr-data/-/merge_requests/76Convert the About Pd-l2ork text to DOS line endings.2017-02-12T20:41:46ZAlbert GräfConvert the About Pd-l2ork text to DOS line endings.Fixes #248. Yeah, I know it's ugly, but even in this day and age Windows' splendid Notepad editor won't display a file with Unix line endings properly. It all becomes a single line which makes the About message somewhat hard to read. :)
...Fixes #248. Yeah, I know it's ugly, but even in this day and age Windows' splendid Notepad editor won't display a file with Unix line endings properly. It all becomes a single line which makes the About message somewhat hard to read. :)
Note that I'm definitely *not* suggesting that we have to change all the other text files in the docs. If a Windows user opens one of those, he's supposedly aware that he's opening a text editor and might be expected to run a *real* editor such as Emacs or Notepad++ as his default text editor.
But when a Windows user first runs Purr Data and clicks on the About Pd-l2ork menu command, we can't expect her to deal with this. It *should* display properly no matter what editor gets launched, and on Windows this will most likely be ye olde Notepad.
Since the change is harmless for Linux and Mac where editors actually know how to deal with DOS text files, I'd say that this is the easiest and most straightforward way to fix #248. Unless we want to add a "real" About box instead of just launching a text editor.https://git.purrdata.net/jwilkes/purr-data/-/merge_requests/77Make sure that inmidi_clk() is called in the right place in the MIDI back-end...2017-02-14T00:59:20ZAlbert GräfMake sure that inmidi_clk() is called in the right place in the MIDI back-end. Fixes #255.Remarks:
- Note that I didn't fiddle with the implementation of the midiclkin object itself, which seems to be all right. I just made sure that it gets triggered in the appropriate place.
- There isn't any useful documentation whatsoev...Remarks:
- Note that I didn't fiddle with the implementation of the midiclkin object itself, which seems to be all right. I just made sure that it gets triggered in the appropriate place.
- There isn't any useful documentation whatsoever for this object, so it's up to anyone's guess what the timebase for the time deltas in the right outlet should be. I've chosen msecs for now, which is in line with the default unit used by metro, delay, etc.
- There *is* noticeable jitter in the time diff values, but that's to be expected with the simplistic implementation of midiclkin which just reports the deltas as they are. So in order to actually do some professional-grade tempo tracking or syncing with this thing, the user still has to think about some appropriate averaging process -- I'm not an expert on this, but I've been told that one can use PLLs = phase locked loops for that kind of thing.
Ok, there you have it. At least the object now does something sensible. :)https://git.purrdata.net/jwilkes/purr-data/-/merge_requests/78Loader fixes backport from vanilla2017-02-20T21:54:35ZAlbert GräfLoader fixes backport from vanillaAs discussed in #266. The backported loader changes are all in a single commit. The second commit (rev. 63a5ae55) merely bumps the vanilla version to 0.47.0 which is in order now because of the change of the loader_t callback type in the...As discussed in #266. The backported loader changes are all in a single commit. The second commit (rev. 63a5ae55) merely bumps the vanilla version to 0.47.0 which is in order now because of the change of the loader_t callback type in the loader extension API.Jonathan WilkesJonathan Wilkeshttps://git.purrdata.net/jwilkes/purr-data/-/merge_requests/79libdir: Revert to previous Makefile (new one broke the Windows build).2017-02-20T22:13:04ZAlbert Gräflibdir: Revert to previous Makefile (new one broke the Windows build).Augments !78 to fix the Windows build hiccup with libdir, as discussed in the comments there.Augments !78 to fix the Windows build hiccup with libdir, as discussed in the comments there.https://git.purrdata.net/jwilkes/purr-data/-/merge_requests/80Backport of vanilla signalin fixes2017-02-23T01:25:23ZAlbert GräfBackport of vanilla signalin fixesAs discussed on the pd-l2ork mailing list. This backports some bugfixes related to signal inlets from the 0.47.0 vanilla release.
- The crucial one, which fixes the "signal inlets without a main signalin" issue, is in rev. 65e3cfab6ee1b...As discussed on the pd-l2ork mailing list. This backports some bugfixes related to signal inlets from the 0.47.0 vanilla release.
- The crucial one, which fixes the "signal inlets without a main signalin" issue, is in rev. 65e3cfab6ee1b5ba8889ae789b0f1594a9c0a638. (Note that I didn't attempt to backport Miller's entire work on the clone~ object which this was part of. I think that we should keep that separate, we can always do that later.)
- IOhannes' commit d7432e4aa0b9da7c79652e8176f38df648648bdf deals with some corner cases of the "signal outlet connect to nonsignal inlet" error. I added that simply because it's obviously related to the aforementioned issue. Note that we also had some corresponding code in there, but IOhannes' solution seems simpler and cleaner, so I'd say that we should go with it. Also, this puts our d_ugen.c in perfect sync with vanilla again. (In fact I just copied the vanilla version over, that's how this commit came about.)
- Rev. dc897de629a4222ebc8d7fc3554442665ea56e56 isn't directly related, but it's part of the same release, and it also fixes an issue with signal inlets, so IMHO it would be good to merge this as well while we're at it.
Tested on Linux, will test on Mac next. As always, it would be nice if you could try a test build on Windows so that we know that we're good there, too.https://git.purrdata.net/jwilkes/purr-data/-/merge_requests/81Zoom wheel scroll action needs cmd/ctrl modifier in canvas window (fixes #94).2017-03-08T01:05:50ZAlbert GräfZoom wheel scroll action needs cmd/ctrl modifier in canvas window (fixes #94).Jonathan WilkesJonathan Wilkeshttps://git.purrdata.net/jwilkes/purr-data/-/merge_requests/82Make intelligent patching mode 4 controllable with the ctrl modifier.2017-03-09T09:06:53ZAlbert GräfMake intelligent patching mode 4 controllable with the ctrl modifier.Intelligent patching mode 4 often just always prefers option A (outgoing
connections). But if the user actually wants option B (incoming connections),
he can't get it because option A was chosen. This is confusing, which is why
mode 4, w...Intelligent patching mode 4 often just always prefers option A (outgoing
connections). But if the user actually wants option B (incoming connections),
he can't get it because option A was chosen. This is confusing, which is why
mode 4, while very useful if it works as intended, can be rather difficult to
use right now.
We therefore now take into account the status of the ctrl modifier, which
simply reverses our choice of option A or B, so that the user now has a way of
getting option B even if option A is preferred (and vice versa). If the ctrl
modifier isn't pressed, mode 4 works exactly as before, so this change is
fully backwards-compatible.
See also the discussion in #262.https://git.purrdata.net/jwilkes/purr-data/-/merge_requests/83Comment change.2017-03-15T02:36:04ZAlbert GräfComment change.Fixes the comment glitch in the intelligent-patching help patch reported by @ssfrr in !82.Fixes the comment glitch in the intelligent-patching help patch reported by @ssfrr in !82.Jonathan WilkesJonathan Wilkeshttps://git.purrdata.net/jwilkes/purr-data/-/merge_requests/84fix #280: duplicate messages aren't printed after clearing the console2017-03-12T22:37:59ZJonathan Wilkesfix #280: duplicate messages aren't printed after clearing the consolea quick bugfix for the console printing error.
I'd like to get in the habit of using merge requests, even on my own repo. That way I can trigger CI and test out binaries before committing to master.a quick bugfix for the console printing error.
I'd like to get in the habit of using merge requests, even on my own repo. That way I can trigger CI and test out binaries before committing to master.Jonathan WilkesJonathan Wilkeshttps://git.purrdata.net/jwilkes/purr-data/-/merge_requests/85Speed up the saving of the preferences on macOS.2017-03-16T00:03:44ZAlbert GräfSpeed up the saving of the preferences on macOS.This is done by importing the config data using `defaults import` in
one go, which is *much* faster than the previous implementation which
invoked the shell to run `defaults write` for each individual key.This is done by importing the config data using `defaults import` in
one go, which is *much* faster than the previous implementation which
invoked the shell to run `defaults write` for each individual key.Jonathan WilkesJonathan Wilkeshttps://git.purrdata.net/jwilkes/purr-data/-/merge_requests/86Minor improvements in the loading of the preferences on macOS2017-03-16T10:44:21ZAlbert GräfMinor improvements in the loading of the preferences on macOSAs discussed in the aftermath of !85. This cuts out the `defaults export` command from the prefs loading pipeline which isn't really needed. While I was at it, I also fixed up some wrong help paths in the default prefs (apparently inheri...As discussed in the aftermath of !85. This cuts out the `defaults export` command from the prefs loading pipeline which isn't really needed. While I was at it, I also fixed up some wrong help paths in the default prefs (apparently inherited from Pd-extended), so that these point to Library/Pd-l2ork now.
Tested on Sierra, works fine for me. Default prefs are still loaded if no user prefs are present, and UTF-8 in the prefs also still works.Jonathan WilkesJonathan Wilkeshttps://git.purrdata.net/jwilkes/purr-data/-/merge_requests/87Fix the Markdown in README.md2017-03-18T07:08:37ZAlbert GräfFix the Markdown in README.mdSome gentle reformatting to make the Markdown more standards-compliant, so that it renders correctly on Github (still renders correctly on Gitlab as well).
Here's how the old version looks like on Github: https://github.com/agraef/purr-...Some gentle reformatting to make the Markdown more standards-compliant, so that it renders correctly on Github (still renders correctly on Gitlab as well).
Here's how the old version looks like on Github: https://github.com/agraef/purr-data/tree/master (note that the line breaks and the formatting of the verbatim code sections is badly garbled)
The new version looks all right: https://github.com/agraef/purr-data/tree/readme-fixes
The new version also looks all right on Gitlab: https://git.purrdata.net/aggraef/purr-data/tree/readme-fixesJonathan WilkesJonathan Wilkeshttps://git.purrdata.net/jwilkes/purr-data/-/merge_requests/88About patch (fixes #248)2017-03-20T00:22:15ZAlbert GräfAbout patch (fixes #248)As discussed in #248. Tested on Linux (Arch) and macOS (Sierra). Here's how it looks like on Linux:
![about-linux](/uploads/2281d4f43d474940f05a3102eb301467/about-linux.png)
Notes:
- `@pd_help` didn't work on the Mac for me, so ...As discussed in #248. Tested on Linux (Arch) and macOS (Sierra). Here's how it looks like on Linux:
![about-linux](/uploads/2281d4f43d474940f05a3102eb301467/about-linux.png)
Notes:
- `@pd_help` didn't work on the Mac for me, so I used `@pd-extra/../doc` for the local links instead for now. (I think that we should take a look at the expansion of `@pd_help` some time, I don't think that the current implementation is correct.)
- I simply added all the cat_thing pngs, but only a small (and constant) subset of those is actually used for the little animation right now. So there's still ample opportunity to beef this up. I'm not much of a graphics artist, so feel free to rework it as you see fit. :)
- I'm not sure about the status of these included graphics. Did you create them yourself? Then you might want to add a license note there (Creative Commons maybe?). Otherwise, can we freely redistribute them?
- Rev. 87d85e57e2e2504c2e772f0f452437f5adf2e97b adds some cp commands to makefile.in and makefile.mingw so that the graphics files are installed along with the about patch. I hope that the changes in makefile.mingw will do the job, but as usual I couldn't test there, so it would be nice if you could give it a whirl on Windows (if the about patch comes up empty, then it's most likely due to a goof in the added line in makefile.mingw).Jonathan WilkesJonathan Wilkeshttps://git.purrdata.net/jwilkes/purr-data/-/merge_requests/89Overhaul the license files for more extensive and clearer license information.2017-03-20T17:10:29ZAlbert GräfOverhaul the license files for more extensive and clearer license information.Clarify the license terms of the package as well as its bundled components,
and place the original license files into the main directory of the source, so
that everybody can find them easily. The source is in Markdown format for
easier e...Clarify the license terms of the package as well as its bundled components,
and place the original license files into the main directory of the source, so
that everybody can find them easily. The source is in Markdown format for
easier editing (LICENSE.md), from which the html file (LICENSE.html) can be
generated with: pandoc LICENSE.md -o LICENSE.html. The html file is now used
in packages/Makefile to generate the License.html file to be included in the
package.
Tested on Arch Linux, macOS Sierra and Windows 8.1.https://git.purrdata.net/jwilkes/purr-data/-/merge_requests/90lyonpotpourri fixes2017-03-21T21:49:48ZAlbert Gräflyonpotpourri fixesAs discussed in #282. Switch to https://github.com/ericlyon/lyonpotpourri3.0 for the latest version which resolves 64 bit issues on Linux and macOS.
Tested on Linux (32 and 64 bit) and macOS (64 bit) so far, works fine on all of these...As discussed in #282. Switch to https://github.com/ericlyon/lyonpotpourri3.0 for the latest version which resolves 64 bit issues on Linux and macOS.
Tested on Linux (32 and 64 bit) and macOS (64 bit) so far, works fine on all of these. (At least I can load up all help patches with dsp on without Purr Data crashing.) @jwilkes, I'm currently running a test build on Windows, but this will still take a while (old computer), so I've tagged this as WIP until I'm done testing it there, but I thought that I should already put this up here so that you can run your own tests if you want.
Also note that this branch probably works best if you check it out in a fresh clone, because git easily gets thrown off if you already have a submodule checked out at a different url and/or revision.
For the record, even in the latest version, lyonpotpourri has some buggy objects which can make Purr Data crash. These should be reported upstream, so I'm listing our findings here:
- [bashfest~] crashes when dsp is on and it is invoked without creation arguments (or if it can't find its sound file).
- [epluribus~] sometimes crashes when *closing* the corresponding help patch while dsp is on.
- The [vecdex~] help patch doesn't work because its fft-hipass subpatch uses a [greater~] object which doesn't seem to exist in Purr Data (at least it isn't found with the default library paths). That might be an issue with lyonpotpourri or with Purr Data, I don't know.Jonathan WilkesJonathan Wilkeshttps://git.purrdata.net/jwilkes/purr-data/-/merge_requests/91dropdown: comment out debugging code2017-03-22T13:51:57ZAlbert Gräfdropdown: comment out debugging codeJonathan WilkesJonathan Wilkeshttps://git.purrdata.net/jwilkes/purr-data/-/merge_requests/92Need to expand ~ et al when checking for the existence of search paths. Fixes...2017-03-24T21:19:04ZAlbert GräfNeed to expand ~ et al when checking for the existence of search paths. Fixes #293.Tested on Linux so far, will test on the Mac in a minute.Tested on Linux so far, will test on the Mac in a minute.Jonathan WilkesJonathan Wilkes