GitLab

fixed rx and ry methods, update scrollbars when scalar is displaced, and update bbox on changes to visibility and stroke-width

*patch to add [group] data structure and supporting fixes (work in progress with lingering bug of being unable to display data structure arrays properly, see tiger.pd demo patch in data structures)

- nested plots display properly
- plot is vis'd and unvis'd properly when deleting plot or struct
- commented out ugly plot_displace hack-- multiple plots should work just fine
- separated out garray dependencies into class "old_plot".  This way the changes I made don't affect garrays.  _Very_ ugly hack, but it was pretty simple to implement and will be easy to remove later.
- no crashes when non-existent arrays are entered into a [struct] that has scalars hanging around
- template_cancreate ported from 0.45
- added a function to get the offending struct (to use with "Find last error").  Not using it yet, though.
+ For creating scalars using an object box:
- scalar must have initial "float x float y" fields, in that order.  This means you can't accidentally type the name of the hidden garray structs and create a scalar.  (Nor any other structs that only have a "y" field, etc.)
- broken object box returned if the struct has a bogus array template.  (Although currently I'm just refusing to create such a struct.)

code clean-up and enabling bunch of debugging to hunt down the infinite recursion in the scalar-help.pd (select the left object and observe your own aging process)

*cannot create two structs on the same canvas (otherwise how would you know which one you are talking to)?
*fixed regression where arbitrary font sizes were not honored by the drawsymbols and drawnumbers
*other minor clean-ups
*adjusted help file to reflect the new approach to font sizes

fixed scrolling algorithm for scalars, improved scrolling logic to avoid unnecessary updates, made scrollbars wider (easier to click) and less transparent

implemented improved version of the g_scalar parsing of owner glist to adopt proper repositioning of scalars.

added dynamic getscroll call whenever a scalar is altered to ensure proper updating of the srollbars

*updated latest additions by Jonathan--still need following fixes:
1) enter-leave demos don't work at all (any demo involving enter-leave)
2) crasher in easing is still valid
3) spin-spin-spin crashes pd-l2ork when trying to close the patch while the image is spinning and being animated
4) curve-bbox is still having accuracy issues (tkpath issue)
5) polar clock still exhibits issues of warping curve (tkpath issue)
6) On the 15.events.pd change call is never issued--is this another side-effect of me not applying everything?
7) Is there a 14. patch for ds-tutorials? I didn't find one.
8) in ds-tutorials is gmon.out necessary or is this a stale file?

additional improvements and fixes for regressions introduced in the last mega-patch by Jonathan Wilkes

*fixed bug where with JOC enabled in subpatch this only works for the bbox of the array, not the entire window
*made intelligent offset to various forms of array representations so that scrubbing with mouse accurately applies to closest points
*disabled drawing of a GOP rectangle inside GOP array window
*disabled ability to insert objects inside a subpatch with an array

*fixed incorrect getrect when selecting a plot with scalars at each point (see setsize-help.pd). This was a regression from an earlier "fix" (see https://github.com/pd-l2ork/pd/commit/f0916f85a11894a43067d5b07ae5f8eea2b2c1b9#diff-5ff2b78bd60b3b9c36db43b8d5f5c168). The latest code does not exhibit the said problem so this should be all ok.
*fixed embedded scalars at each plot point not being selected for displacement with tag due to clumsy way of labeling them. This is achieved by adding scalar arg to the parentvisfn which also alters g_canvas.h spec but also makes things more streamlined.

*better getrect for scalars inside plot/array (entire points are now selectable instead of arbitrary rectangle around the object)

*fixed drawsymbol scalars' double names
*improved build process for tkpath
*improved to-front/back logic

first stab at porting core GUI to tkpath with SVG goodness. new scrollbars that will hopefully put an end to the old painful scrollbar nonsense. pdtk_tip clean-up and improvements. tons of other small bug fixes. a number of issues/wishlists still exist before the next big release:
*improve g_array lower/raise to use new functionality (BUG! doesn't match any items)
*scalar is drawn behind at first
*Scope~ window name "h16ffd10" already exists in parent (likely resize hook)
	*Change appearance of the resize hook
*better getrect for scalars inside plot?
*reenable bgerror and t_tkcmd catch
*Clean-up and merge cyclone documentation

experimental implementation of disabling drawing outside the GOP array boundaries (currently disabled)

Fixed bug http://sourceforge.net/tracker/index.php?func=detail&aid=2457992&group_id=55736&atid=478070; hopefully also fixed incorrectly reported hit/selection boxes for nested structs (like the one reported in the previous bug report)

fixed stray bugs that were introduced with drawsymbol and resizable fonts and made drawnumber font resizable as well

fixed wrong color fill for selected gop object when opening gop-ed subpatch, incorrect selection of all scalars inside gop-ed patch when it is being edited as a toplevel window, and a bug where repeatedly opening already open gop-ed patch does not re-focus its toplevel window

altered behavior of gop objects so that internal elements are not visibly selected. Also reworked the way array and scalar selection is dealt with fixing segfault and making a more fool-proof way of selecting them.

Fixed segfault when creating undo for array apply (e.g. when changing array size). Also expanded moving by tag to arrays and scalars. Now, the entire array even with a ton of points is moving like knife through the butter :-)