GitLab

This change allows curly braces {} to be accepted as keypress events and entered into object and message boxes. It doesn't change the quoting rules for these characters, so [print] still escapes them with backslashes.

These happen in Pd-Vanilla and Pd-l2ork, too. They happen when an iemgui is inside
a gop window and outside of the gop rectangle area-- Pd still forwards gui
messages for them.

These bugs were discovered via static code-analysis
https://scan.coverity.com/projects/pure-data-pure-data
(The CID numbers are the "Coverity IDs" used to identify the various bugs)

- Don't free binbuf within glist_readfrombinbuf (CID:74871)
- it must be deleted by the caller
- Initialize sockaddr_in (CID:74861,74862,74863,74866)
- Initialize indelay/outdelay (CID:74864,74865)
- Initialize device-arrays (CID:74853,74854,74855,74856)
- Closing unneeded sockets (CID:74827)
- Initialize sockaddr_in (CID:74860}
- Close file-descriptor if the soundfile is unparsable (CID:74822,74823)
- Close file-handle in cleanup (CID:74816)
- Call va_end() when handling variadic args (CID:74872)
- Added missing break (CID:74800)
- Prevent NULL-dereferences (CID:74792,74793)
- Size checks when copying into string buffers (CID:74844,74845,74846,74847,74849)
- Freeing no-more used storage (CID:74832)
- Fixed code block (CID:74806)
- Initialize sockaddr_in (CID:74860)
- Initialize array-values to 0 (CID:74867)
- Free allocated memory (CID:74813,74830)
- Removed allocation of unused memory
- Use pd_free() to free templates (CID:74814)
- template_free() does not free the entire structure (it misses the pd_new() part)
- initialize variable (CID:77865)
- Prevent NULL-pointer dererencing (CID:77864)
- Free heap-allocate binbuf after use (CID:74833)

fix awful regression where deleting the end of a comment, a message, or the trailing arguments of an object didn't actually change the state of the object in Pd.

add my_canvas_class conditional in g_editor.c to disallow resize anchor, since it abuses an extra label handle for resizing.

* check canvas visibility in iemgui_displace
* check visibility before updating scroll in canvas_dofont

also some small formatting fixes

port a031e3b64f725c8cb3274b5ef3ff0e27a36222f5 from Pd-l2ork: fixed parsing of @pd_extra and @pd_help names in filenames

port 9ab1b10476bca7e3998d5bf907296979dfc6e558 from Pd-l2ork: fixed regression where canvaslist was not properly stored

port c6771297b6f03887034c5f121d3dbf701623ab87 from Pd-l2ork: the big Vanilla forward port won't compile without this commit

when selecting/deselecting individual objects on the canvas (e.g two objects where one cover the other, typically the one below would be selected/deselected first instead of the top one)

got scopehandle clicks working... now need to port scopehandle motion by adding a wrapper in canvas_motion of g_editor.c for Scope~

* simplify GUI API
* get rid of canvas_createobj

first attempt at lifting the limitation on the size of text typed in new objects in the GUI which get sent to Pd. We're sending in chunks smaller than the buffer to achieve this.
* this needs a lot more testing
* still subject to Pd's limit of 1000 bytes per t_symbol
* probably want to protect the new canvas methods from segfaults in case the users start fooling around with them

*fixed bug reported by Liam Goodacre regarding donecanvasdialog causing parent patch to open in case subpatch's properties have been changes (e.g. via scripting). See http://disis.music.vt.edu/pipermail/l2ork-dev/2016-January/000810.html for more info.

*Reverted http://sourceforge.net/p/pure-data/pure-data/ci/97851b3c44b2b3839069928d90ca6185de4455c5/ as it disables ability to address abstractions via scripting (needs further testing to figure out why was this disabled in the first place and then later reverted by Miller)
*fixed way of vis-ing GOP-enabled abstractions via script

first try at get the copyfromexternalbuffer logic ported. This allows to paste Pd source code into a patch

comment out some sys_vgui calls which are _probably_ no longer necessary (plus extra comments saying as much)

remove pdtk_check_scroll_on_motion for the time being. (Not sure it's needed, but can revisit if necessary)