From 62a91280cdc445d733e2bbc3e7c36aeb3dc930de Mon Sep 17 00:00:00 2001
From: Jonathan Wilkes <jon.w.wilkes@gmail.com>
Date: Thu, 17 Nov 2016 21:03:20 -0500
Subject: [PATCH] =?UTF-8?q?fix=20#82:=20"Select=20all"=20shortcut=20(cmd+A?=
=?UTF-8?q?)=20doesn=E2=80=99t=20work=20(on=20OSX)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
---
pd/nw/pd_canvas.js | 5 +++++
pd/nw/pd_menus.js | 11 +++++++++++
2 files changed, 16 insertions(+)
diff --git a/pd/nw/pd_canvas.js b/pd/nw/pd_canvas.js
index 0b582fd9b..977beb922 100644
--- a/pd/nw/pd_canvas.js
+++ b/pd/nw/pd_canvas.js
@@ -1080,6 +1080,11 @@ function nw_create_patch_window_menus(gui, w, name) {
click: function (evt) {
if (canvas_events.get_state() === "normal") {
pdgui.pdsend(name, "selectall");
+ } else if (process.os === "darwin") {
+ // big kluge for OSX to select all inside a
+ // contenteditable element (needed because
+ // the stupid MacBuiltin is buggy-- see pd_menus.js)
+ document.execCommand("selectAll", false, null);
}
}
});
diff --git a/pd/nw/pd_menus.js b/pd/nw/pd_menus.js
index 9342be984..a839d3149 100644
--- a/pd/nw/pd_menus.js
+++ b/pd/nw/pd_menus.js
@@ -152,7 +152,18 @@ function create_menu(gui, type) {
// There's no "Delete" item for GNU/Linux or Windows--
// not sure yet what to do with it.
m.edit.delete = window_menu.items[1].submenu.items[6];
+ // The MacBuiltin "Select All" doesn't propagate down to the DOM
+ //on OSX, so we have to remove it
m.edit.selectall= window_menu.items[1].submenu.items[7];
+ window_menu.items[1].submenu.remove(m.edit.selectall);
+ // Now we replace it with a custom "Select All" which will
+ // propagate to the DOM...
+ edit_menu.append(m.edit.selectall = new gui.MenuItem({
+ label: l("menu.selectall"),
+ tooltip: l("menu.selectall_tt"),
+ key: "a",
+ modifiers: cmd_or_ctrl
+ }));
} else {
edit_menu = new gui.Menu();
// Edit sub-entries
--
GitLab