GitLab

fixed confirming saving changes on an abstraction hidden inside another patch (currently invisible) whose prompting failed...

Improved logic for intelligent asking when to save abstractions. No longer is it necessary to check whether to save an abstraction after it has been changes and only displaced on parent. this is because objects are "activated" when selected which potentially means that abstractions would be recreated as soon as they are deselected essentially making user lose anything they changed in the abstraction and did not save. However, in pd-l2ork we check when objects are activated whether their rtext (and therefore also its arguments) have changed and only recreate object if they did.

fixed three regressions that crept in due to implementation of moving gop objects by tag. one of them manifested itself when an object was altered as gop and a sub-patch pops up asking to discard changes made to it. upon returning on the main window with the said gop, due to redraw objects were not reselected so dragging the object would not redraw properly even though it could be displaced, resulting in a seemingly stale gop object (in actuality it was simply displaced by being dragged while its visual content did not displace). Also, excessive stdout errors regarding redrawing gop resize handles and possible menu edit update has been dealt with.

Fixed segfault when creating undo for array apply (e.g. when changing array size). Also expanded moving by tag to arrays and scalars. Now, the entire array even with a ton of points is moving like knife through the butter :-)

finished implementation and debugging of infinite undo. removed debugging statements from stderr, vastly improved pasting from external script.

finished undo implementation, added consistency to how canvas properties window is handled in undo situations, removed debug output.

added comments that suggest UCUT_TEXT is now obsolete and replaced by a much better undo_recreate (action 10).

more improvements to the cut mechanism. implemented rename function (11th undo action proved unnecessary and is serviced by 10). improved logic of retexting objects so that only those that have changed trigger an undo snapshot.

added more improvements to the infinite undo and reworked existing undo actions to conform to the infinite undo model. fixed per-window undo menu updating, finalized undo actions 1,2,3,4,5,9, and 10. Still need 6,7,8 and a new action 11 (namely apply, canvas apply, to front/back, and rename). Also improved paste behavior to make it more user friendly, particularly within the context of infinite undo.

major overhaul of existing undo actions to conform to the infinite undo format, changed how undo create functions, started undo recreate, reformatted undo index, a number of minor bug fixes, implemented undo actions index 1,2,4,5, and 9 and started working on 10.

implemented first layer of infinite undo (type 8, create only, at this point in time), other undo/redo actions are currently broken until they are implemented accordingly. still need to do repointer and purge_abstraction_actions. Also fixed a small lingering bug in canvas_undo_set_create.

added proper repositioning of objects after they have been cut/deleted followed by an undo/redo which always places them at the end and thus makes redoing of cut buggy as it originally relied on whatever selection one had as opposed to the proper original selection.

Fixed nasty bug where doubly-embedded pd canvases (not abstractions) did not redraw properly (affects all known versions of pd) plus additional clean-up and improvements on the gop redrawing/apply logic including ability to limit minimum size on gop-enabled objects without parents that also do not have hidetext enabled.

added gop move/resize via gui, improved logic on autoresizing objects to accomodate space for nlets (GOP-ed objects with hidden text can be of just abuot any size)

Cleaning up code plus attempts at improving script-based dynamic closing/opening of patches (as per Jonathan's request).

*fixed graph-on-parent enable/disable does not activate undo/redo on the parent window (or the gop-ed patch unless it is open)
*improved verifyquit mechanism to accomodate abstractions
*fixed bug where hide text value was not properly interpreted by the canvas apply redo/undo
*fixed stray stderr tcl/tk errors

Cleaned-up paste from external text into canvas feature, enabled the said paste action, and added ability to relocate and resize canvas as part of pasting into an empty canvas. If pasting into a canvas already populated with at least one object, the paste of the said information ignores canvas properties and pastes objects at mouse

Fixed segfault when trying to paste partially copied (and thus erroneous) patch from an external source (e.g. a text editor) where the copied contents contain only "connect" instructions.

Added universal copy and paste allowing importing of patches by copying and pasting the text directly into the patch. Still need to decide whether auto-resizing of the window is also desirable (there are both pros and cons).