Skip to content
Snippets Groups Projects
  1. Aug 13, 2017
  2. Aug 12, 2017
  3. Aug 10, 2017
  4. Aug 09, 2017
  5. Aug 08, 2017
  6. Aug 07, 2017
  7. Aug 05, 2017
  8. Aug 04, 2017
  9. Jul 31, 2017
    • Jonathan Wilkes's avatar
      intermediate state for the tests: · 04ebaffd
      Jonathan Wilkes authored
      * the original namespace-collision checker only worked for abstractions
      * trying a new namespace-collision checker revealed about 80 new clashes.
        Since there are so many it's probably too disruptive to remove them.
      * probably need to revert the namespace clash abstraction removals
      04ebaffd
  10. Jul 29, 2017
  11. Jul 28, 2017
    • Jonathan Wilkes's avatar
    • Jonathan Wilkes's avatar
    • Jonathan Wilkes's avatar
      b02fceba
    • Jonathan Wilkes's avatar
      remove copies of mapping library abstractions from la-kitchen · 0fdcd2a4
      Jonathan Wilkes authored
      I don't see any use of the namespace prefix in the repo (like
      la-kitchen/amplitude_n). So while this has the potential to break
      some patches in the wild, it appears most people have been using
      either unprefixed names or the more popular mapping library prefix.
      
      If this ends up breaking a bunch of stuff we can always revert it.
      0fdcd2a4
    • Jonathan Wilkes's avatar
      allow class_addcreator to register an additional creator with the namespace prefix if one was used · 7cfac026
      Jonathan Wilkes authored
      This will allow legacy externals like iemmatrix and zexy to properly load
      aliases the first time when the user instantiates an object with
      [namespace_prefix/alias_name]
      
      This becomes relevant when there are kludge classes that essentially just
      "#include" the original C file of a class and add an alias_setup function
      which just calls the original setup routine. (For example, see iemmatrix.)
      However, such an approach still calls class_new with the original class name.
      Thus "namespace_prefix/classname" gets added to the pd_objectcreator
      methodspace, but "namespace_prefix/alias_name"-- which is what we want--
      does not. This results in a series of 1000 recursive calls into
      pd_objectmaker's new_anything method. (I.e., sys_load_lib finds the
      "namespace_prefix/classname" is already loaded, new_anything_sends a
      typedmess to pd_objectmaker's new_anything method, which calls
      sys_load_lib, etc.)
      
      To prevent this, we just make sure to add "namespace_prefix/alias" by
      adding the relevant lines to class_addcreator. This should really be
      happening anyway-- since internal classes don't have a class_loadsym
      they aren't affected, and externals with aliases won't work with
      namespace prefix without this.
      7cfac026
Loading