Albert Gräf authored 2 years ago and Albert Gräf committed 2 years ago

This was completely rewritten in order to minimize the changes to the
existing text dialog interface. In particular, the text buffer used in
hammereditor_append is now maintained on the C side. This additional
buffer is required by the cyclone objects which call this routine to
populate the hammereditor before the text dialog window is mapped, so
gui_text_dialog_append doesn't work in that context.

The only essential change in the text dialog interface is in the way the
window position gets passed to the gui_text_dialog routine. We have two
new x, y arguments there which are necessary to make the click actions
of various cyclone objects work. The text object in x_text.c, which is
the only other object where this gui call is being used, was modified
accordingly, and seems to work alright with this change.

Replaces non-functioning legacy (tcl/tk) calls. Backport from DISIS
Pd-l2ork, cf. https://github.com/pd-l2ork/pd-l2ork/commit/8a93fa83.
Thanks Ico!

Please note that this needed quite some editing to apply cleanly to our
codebase and to get rid of whitespace glitches obfuscating the real
changes. So our changeset looks different from the original commit, but
that's (mostly) cosmetic.

Albert Gräf authored 2 years ago and Albert Gräf committed 2 years ago

- Backported some GUI regression fixes from DISIS Pd-l2ork.

- Better icons for win32 and win64 inno (converted from the png icons).
  The ones we had looked dated and terribly blurry on modern hi-dpi
  displays.

- Cleaned up linux_make: Got rid of some obsolete stuff and removed some
  of the l2ork branding.

This has the wrong zoom factors anyway, and we can replace it with
zoom_kludge which has the right factors (albeit their reciprocals).

Albert Gräf authored 2 years ago and Albert Gräf committed 2 years ago

Remove some really old cruft from the Linux package that hopefully
nobody uses any more. Also remove the l2ork branding as much as we can
in icons, desktop files, etc., while ensuring that a straight `make &&
make install` from source still does the right thing. Adjust the debuild
accordingly.

See:
- https://github.com/pd-l2ork/pd-l2ork/commit/3be1bac4
- https://github.com/pd-l2ork/pd-l2ork/commit/37153fa4
- https://github.com/pd-l2ork/pd-l2ork/commit/b7f94f4f

The first two are Mac-specific, the third bug applies to all platforms.

- Cmd+Q not actually quitting after replying "no" to a save prompt. This
  is at odds with the behavior on other platforms. We need to actually
  call pdgui.menu_quit() in the appropriate handler after the last patch
  window was closed and we're about to quit. (That call doesn't seem to
  be needed on Linux and Windows, but it doesn't seem to do any harm
  there either.)

- Patch window growing vertically after each save on the Mac. To fix
  this, the menu bar height of 25 needs to be accounted for in
  canvas_check_geometry, even though the canvas actually has no menu bar
  on the Mac. It is not entirely clear why this is needed, but most
  likely it's due to the way that canvas_relocate works, which can't be
  changed since it's an official vanilla API.

- Subpatch window forgets its geometry when closed and re-opened. Fixed
  by calling canvas_check_geometry in the close event and menu option,
  as we already do in the save and saveas menu options.

This makes my life less miserable when doing releases on the GH mirror,
because I don't have to manually edit the installer filenames before
uploading any more.

GitHub doesn't like blanks in upload file names, using dashes instead
makes uploading much easier and eliminates the need to zip the installer
before uploading. We also include a proper cpu architecture designation
(x86 or x86_64) in the output file name in lieu of the '(64 bit)' suffix
which causes trouble in GH uploads as well, because of the parentheses.

Note that this shouldn't affect the Gitlab CI since it looks for a
'Purr*.exe' build artifact, which will still match the package name.

pd-lua now uses the latest pd-lib-builder and includes lua as a
submodule, so building it becomes a lot easier. Most notably, Lua 5.4 is
linked statically from lua/onelua.c, so Lua isn't needed as a build or
runtime dependency any more and the resulting external will use exactly
the same Lua version across different platforms.