Skip to content
Snippets Groups Projects
Commit 40a25a2a authored by Jonathan Wilkes's avatar Jonathan Wilkes
Browse files

use uint32_t to ensure alignment in union, improve comments

parent fdb1fcc6
Pipeline #
Hide whitespace changes
Inline Side-by-side
Showing
with 20 additions and 6 deletions
  • Matt Barber @brbrofsvl ·

    Line 789: f > abs(2^65) or < abs(2^-63)

    I think this should be abs(f) >= 2^65 or < 2^-63

    same problem at line 819

  • Albert Gräf @aggraef ·
    Developer

    Just a remark: unsigned int will always be a 32 bit integer, on just about any conceivable system where Purr Data will be able to run on. I'm wondering, though, whether using uint32_t might be a portability issue. Are we guaranteed to include the proper headers so that it is available, on all Un*x platforms at least?

    Edited by Albert Gräf
  • Jonathan Wilkes @jwilkes ·
    Author Owner

    It passed CI under Windows msys2 which I assume means it found stdint.h ok there.

    What Un*x doesn't have stdint.h?

  • Albert Gräf @aggraef ·
    Developer

    Right, it's (at least) in ISO/IEC 9899:1999 and POSIX 2003, so we should be good there.

0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment