Legacy tcl command in g_canvas.c tripped by about patch
Unfortunately, I can't reproduce this reliably, but while testing Ico's branch for "old" (pre 0.46) nw.js regressions, I sometimes got a message like this in the console when opening the about patch via Help => About Pd-L2ork, so I thought that I might just as well report it:
legacy tcl command at 1815 of g_canvas.c: pdtk_select_all_gop_widgets .x56290a4297b0 56290a392610 1
The line is actually at https://git.purrdata.net/jwilkes/purr-data/-/blob/master/pd/src/g_canvas.c#L1772 in the current master branch (but at line 1815 in Ico's branch), in the
glist_redrawall function. It reads (I've included the two comment lines above for context):
/* Haven't tested scalars inside gop yet, but we probably need a gui_vmess here */ sys_vgui("pdtk_select_all_gop_widgets .x%lx %lx %d\n", glist_getcanvas(gl), gl, 1);
This code is pretty ancient (rev. 4717bd58 "Jonathan's clean-up of the g_canvas.c" submitted by Ico Sat Mar 8 22:32:28 2014 -0500 according to git blame), so this seems to be a leftover from the olden pd-l2ork 1.x days.
I'm not sure how this code gets tripped or why, as I said I couldn't really pin this down because I can only reproduce it by accident so far. It might be tripped by Ico's changes (if so, then maybe by rev. b16cbaed?), but I'm not sure at all about that either. But I'm pretty well sure that we don't want this code to be there in 2020, waiting for its chance to be executed. ;-)
@jwilkes Maybe you can figure out what's up with this legacy tcl call and why it's still there. Maybe we can just comment it out, so that it doesn't by accident rear its head?