nw.js 0.46/0.47 issues

Document regressions with respect to the latest nw.js versions here.

Ok, here is one I noticed on Linux (Manjaro). This seems to be the same with nw.js 0.46.4 and 0.47.2 at least, but works fine in nw.js 0.24.4:

The "Save as" option displays a weird default filename constructed from the pathname instead of just the filename (same goes for the "Save" dialog when saving a new patch):

Well, it seems that that was something I added myself as a workaround for an issue with earlier nw.js versions, which has since been resolved. Quite fitting that this would come back and bite me in the end.

Here's the fix:

diff --git a/pd/nw/pdgui.js b/pd/nw/pdgui.js
index 4c0b269f..6cd4a463 100644
--- a/pd/nw/pdgui.js
+++ b/pd/nw/pdgui.js
@@ -959,7 +959,7 @@ function gui_canvas_saveas(name, initfile, initdir, close_flag) {
         type: "file",
         id: "saveDialog",
         // using an absolute path here, see comment above
-        nwsaveas: path.join(initdir, initfile),
+        nwsaveas: check_nw_version("0.46") ? initfile : path.join(initdir, initfile),
         nwworkingdir: initdir,
         accept: ".pd"
     });

I'm ready to submit a MR for this, but my fix is based on Ico's latest branch in !485 (merged), so that needs to be merged first.

mentioned in merge request !485 (merged)

mentioned in merge request !486 (merged)

Submitted !486 (merged) which has been merged already, so the bug reported above has been fixed. I'm keeping this ticket open, however, for any other issues with nw.js 0.46+ that we might still find.

Ok, here's another one: Preferences don't close with Ok or Close in nw.js 0.4x.

I can reproduce this with nw.js 0.47.2 on Linux as follows: Open the prefs dialog, change something, press Ok. The dialog will close alright the first time. Do it again => Ok still commits the changes, but doesn't close the dialog anymore, neither does the Close button. I have to close the window from the window manager using the x button to get rid of the window.

With 0.22.4 this works every time, so this seems to be a regression for the latest nw.js versions that I've been using lately (0.46+). Also happens on Windows (with nw.js 0.47.3).

mentioned in issue #679 (closed)

mentioned in commit e4f4a0cc

mentioned in commit da224d70