fluid~-help.pd can't be opened

mentioned in merge request !2 (closed)

Status changed to closed by commit 55ef0aec

mentioned in commit aggraef/purr-data@55ef0aec

Status changed to reopened

Ok, this one is fixed now, but cyclone is still giving similar errors. In particular, the seq-help patch never opens. To reproduce: pd-l2ork /usr/lib/pd-l2ork/extra/cyclone/seq-help.pd

Terminal log:

 gui_legacy_tcl_command("../shared/hammer/file.c",73,"text $name.text -relief sunken -bd 1 \");
                                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

SyntaxError: Invalid or unexpected token
    at Socket.perfect_parser (/usr/lib/pd-l2ork/bin/pdgui.js:1195:44)
    at emitOne (events.js:96:13)
    at Socket.emit (events.js:188:7)
    at readableAddChunk (_stream_readable.js:172:18)
    at Socket.Readable.push (_stream_readable.js:130:10)
    at TCP.onread (net.js:542:20)

That's probably because sys_vgui calls often use "\\n" for splitting a long tcl statement across multiple lines.

So your C code should probably split the string on whichever comes first: "\n" or "\"

Sounds plausible. I could modify the code so that it takes care of \ immediately preceding newline.

But I think that real culprit is the gui_vmess() function here. Shouldn't it be able to deal with whatever C string arguments you pass? Or are the strings assumed to already be in proper JS syntax, escapes and all that? That would be a bad idea IMHO.

"Over-the-wire Pd->GUI Format":

Double quotes are string delimiters-- all double quotes inside the string are escaped on the C side before sending over the socket
ASCII 31 (unit separator) delimits messages, since a single-byte delimiter means one less thing to think about when I wrote the GUI-side parser.

It's not even JSON, but a quick-and-dirty format that lends itself to being plugged in to Javascript's "eval" function. It works because there hasn't been a single case where I needed to send a "" or a unit separator to the GUI.

So in this case, the trailing "" ends up escaping the string delimiter, and Javascript complains when it hits a newline.

If you want to make gui_vmess absolutely bullet-proof, feel free. The easier route is to only send the filename and line number to the GUI, or limit the legacy string to alpha-numeric data.

Ok, quick fix for the upcoming alpha: f9cb7772

I'll leave this issue open to discuss ways to make gui_vmess string handling more robust.

Edit: typo

I think that the attached patch for escape_double_quotes should fix the problem. The idea is to escape both " and \ (if you do one, you also have to do the other). Caveat: I'm not at my Linux box right now, so this is completely untested. But I can do that tonight.

s_inter.diff

I can't think of any way to break it. So it seems like that should work.

Ok, testing the fix now, stay tuned...

mentioned in merge request !3 (merged)

Looking good. I just sent you a merge request, or you can also pull from my backslash-fix branch.

Status changed to closed by commit 8292ba16

fluid~-help.pd can't be opened

Designs

Child items ...

Activity