Skip to content

attempt to fix #330: Soundfiler inefficiency (10x memory usage in Purrdata versus Pd-vanilla)

Jonathan Wilkes requested to merge memory-overallocation-fix into master

Don't multiply requested memory size by sizeof(char*)

Edit: The original commit message that added these changes mentioned a memory error detected by valgrind. So we should probably run Purr Data like this to test for regressions:

valgrind pd-l2ork -nrt

(The "-nrt" flag to suppress distracting "pd-watchdog" messages to the console.)

This needs to be thoroughly tested, with a few cases in mind:

  • changing the contents of object/message boxes
  • using dollarsigns in messages, especially $@
  • mixing in some unicode characters
  • any other stress tests we can think of
Edited by Jonathan Wilkes

Merge request reports