Skip to content
Snippets Groups Projects

Experimental: enable curly braces as ordinary characters.

Merged Albert Gräf requested to merge aggraef/purr-data:curly-braces-fix into master

This change allows curly braces {} to be accepted as keypress events and entered into object and message boxes. It doesn't change the quoting rules for these characters, so [print] still escapes them with backslashes.

Merge request reports

Pipeline #645 failed

Pipeline failed for 76bb970f on aggraef:curly-braces-fix

Approval is optional

Merged by avatar (Apr 1, 2025 5:55pm UTC)

Merge details

  • Changes merged into master with 76bb970f.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Albert Gräf mentioned in merge request !30 (closed)

    mentioned in merge request !30 (closed)

  • Author Developer

    I've been running this on my own Linux system for about four weeks now, without noticing any adversarial effects. It's not a grave change (most people probably won't even notice), and the resulting patches seem to load fine even with the current vanilla version. Maybe it could be merged now?

  • Since we're the only ones dev'ing atm I'm fine with that. But once the gitlab ci is stable and we get a release cycle going we should document it and stick to it.

    Also-- go ahead and remove commented-out parts of the relevant expressions. It's actually hard to read those the c-style comments.

  • Albert Gräf added 1 commit

    added 1 commit

    • 76bb970f - Remove commented-out code related to the curly braces fix.

    Compare with previous version

  • Author Developer

    Also-- go ahead and remove commented-out parts of the relevant expressions.

    Done.

    Since we're the only ones dev'ing atm I'm fine with that. But once the gitlab ci is stable and we get a release cycle going we should document it and stick to it.

    Not sure what you're referring to?

  • I mean for release candidates just fixing bugs and such.

  • Author Developer

    Well, for me it is a bug. ;-) But you're right of course, rcs should be for bugfixes only.

  • That's true, but it's a language-level bug which we should treat with care.

    At the same time I've been struggling so long with the build system that the rc's are kind of dragging.

    Anyway, I'll go ahead and merge this one...

    Edited by Jonathan Wilkes
  • Author Developer

    Thanks!

  • One thing to keep in mind-- some people have been talking about using curly brackets in Pd Vanilla to allow nested lists. I'm not sure if that would ever get added as a Vanilla feature, but it could.

  • Author Developer

    Given vanilla's development pace I wouldn't hold my breath for that, but I'll keep an eye on it.

Please register or sign in to reply
Loading