Skip to content
Snippets Groups Projects

add mechanism that visually marks abstraction objects that are edited but unsaved (dirty)

All threads resolved!

add mechanism that visually marks abstraction objects that are edited but unsaved, and all their ancestors. This feature allows the user to easily identify the location of unsaved but edited abstractions that could cause problems and unwanted behaviour.

Was originally included in the WIP patch 'patch private abstractions [ab]'. It has been separated because it doesn't belongs to it, conceptually.

Preview: sc

The colors can be changed if red and orange are not adequate.

Merge request reports

Checking pipeline status.

Merged by Jonathan WilkesJonathan Wilkes 4 years ago (Sep 8, 2020 7:36pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • Resolved by Guillem Bartrina

      Looks good, I'll go ahead and merge.

      As we discussed, I think the bigger problem with abstractions is a user having multiple dirty instances and accidentally overwriting one of them. So we need either:

      1. Warning dialog when the 2nd instance is dirtied, or
      2. Confirmation dialog on save to ask if they are sure they want to overwrite the other dirty abstraction(s).

      I personally like number 1, but I can imagine it frustrated a lot of users. So maybe 2 is the best-- users already expect a dialog on save, so no surprises there.

  • Guillem Bartrina resolved all threads

    resolved all threads

Please register or sign in to reply
Loading