Skip to content

Disable passing of key presses globally when an object grabs focus via glist_grab

Ivica Bukvic requested to merge disable-global-key-when-glist-grabbed into master
  • This means an object has requested exclusive focus

Jonathan, please merge !554 (merged) first so that we can then rebase and fix a trivial conflict in this MR, and also fix up a glist_grab() call in !554 (merged) along the way. Relevant detail:

g_numbox.c:46:5: error: too few arguments to function ‘glist_grab’
   46 |     glist_grab(x->x_gui.x_glist, 0, 0, 0, 0, 0);

This line should become:

g_numbox.c:46:5: error: too few arguments to function ‘glist_grab’
   46 |     glist_grab(x->x_gui.x_glist, 0, 0, 0, 0, 0, 0);

(in other words, just add one more ",0 ")

This is the unfortunate side-effect of small independent fixes getting in the way of each other. Luckily this one is rather simple. LATER: check if !570 cleanly merges, since knob.c has the glist_grab call change as part of this patch, whereas !570 is an independent branch that does not have this change, so there may be a merge conflict.

Edited by Ivica Bukvic

Merge request reports