Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • P purr-data
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 363
    • Issues 363
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 53
    • Merge requests 53
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Jonathan Wilkes
  • purr-data
  • Merge requests
  • !577

Introduced new activated msg border drawing approach

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Ivica Bukvic requested to merge msg-box-0.24.4 into master Sep 30, 2020
  • Overview 17
  • Commits 4
  • Pipelines 4
  • Changes 4
  • Got rid of the problematic svg background which marginally worked on 0.14.7 but doesn't on 0.24.4 (e.g. create a msg object, deactivate it by clicking anywhere on the canvas, and then zoom in a level or two and notice an additional vertical line; also, note that the flags on the right are transparent and not perfectly aligned).

  • Instead, using the existing msg border/background and adjusting its size dynamically

  • The behavior remains identical to before (hide nlets, do not worry about readjusting patch cords)

  • LATER: think about integrating patch cord and nlet adjustment to match vanilla behavior, and implement this same approach for the regular text objects

Edited Oct 07, 2020 by Ivica Bukvic
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: msg-box-0.24.4