Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • P purr-data
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 362
    • Issues 362
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 49
    • Merge requests 49
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Jonathan Wilkes
  • purr-data
  • Merge requests
  • !841

Get rid of the python2 build dependency.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Albert Gräf requested to merge aggraef/purr-data:remove-python2-dependency into master Nov 16, 2022
  • Overview 0
  • Commits 2
  • Pipelines 1
  • Changes 2

Python 2 has been EOL since 2019, and has recently been removed from the Arch repositories, so continuing to support it has become a major hassle for me, especially on the OBS. The quick and dirty fix is to just build the DISIS cwiid library without it, which seems to be the only part of the source which at present still depends on Python 2 at build time. This lets us keep the DISIS externals as they are, while also getting rid of the python2 build dependency.

TBH, I'm not sure whether the disis_wiimote external requires the cwiid Python interface in any way. FWIW, I can't find any Python references in the DISIS external source, so I think that it should be fine without it. But I couldn't actually test this since the disis_wiimote object stopped working for me ever since bluez 5 (i.e., a long time ago).

I've run test builds of this branch on the OBS, all fine on Arch, Debian, Fedora, Raspbian, and Ubuntu. The proposed changeset should only affect Linux systems, but I also made sure that the source still compiles and runs on Mac and Windows anyway.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: remove-python2-dependency