Skip to content

lyonpotpourri fixes

Albert Gräf requested to merge aggraef/purr-data:lyonpotpourri-fixes into master

As discussed in #282. Switch to https://github.com/ericlyon/lyonpotpourri3.0 for the latest version which resolves 64 bit issues on Linux and macOS.

Tested on Linux (32 and 64 bit) and macOS (64 bit) so far, works fine on all of these. (At least I can load up all help patches with dsp on without Purr Data crashing.) @jwilkes, I'm currently running a test build on Windows, but this will still take a while (old computer), so I've tagged this as WIP until I'm done testing it there, but I thought that I should already put this up here so that you can run your own tests if you want.

Also note that this branch probably works best if you check it out in a fresh clone, because git easily gets thrown off if you already have a submodule checked out at a different url and/or revision.

For the record, even in the latest version, lyonpotpourri has some buggy objects which can make Purr Data crash. These should be reported upstream, so I'm listing our findings here:

  • [bashfest~] crashes when dsp is on and it is invoked without creation arguments (or if it can't find its sound file).
  • [epluribus~] sometimes crashes when closing the corresponding help patch while dsp is on.
  • The [vecdex~] help patch doesn't work because its fft-hipass subpatch uses a [greater~] object which doesn't seem to exist in Purr Data (at least it isn't found with the default library paths). That might be an issue with lyonpotpourri or with Purr Data, I don't know.

Merge request reports