Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
purr-data
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container Registry
Model registry
Operate
Environments
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
nerrons
purr-data
Commits
e01b09c3
Commit
e01b09c3
authored
9 years ago
by
Jonathan Wilkes
Browse files
Options
Downloads
Patches
Plain Diff
fix bug with "Save As" not triggering on repeated tries
parent
51d51e62
No related branches found
No related tags found
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
pd/nw/pd_canvas.html
+2
-0
2 additions, 0 deletions
pd/nw/pd_canvas.html
pd/nw/todo.txt
+12
-11
12 additions, 11 deletions
pd/nw/todo.txt
with
14 additions
and
11 deletions
pd/nw/pd_canvas.html
+
2
−
0
View file @
e01b09c3
...
@@ -252,6 +252,8 @@ var canvas_events = (function() {
...
@@ -252,6 +252,8 @@ var canvas_events = (function() {
document
.
querySelector
(
"
#saveDialog
"
).
addEventListener
(
"
change
"
,
document
.
querySelector
(
"
#saveDialog
"
).
addEventListener
(
"
change
"
,
function
(
evt
)
{
function
(
evt
)
{
pdgui
.
saveas_callback
(
name
,
this
.
value
);
pdgui
.
saveas_callback
(
name
,
this
.
value
);
// reset value so that we can open the same file twice
this
.
value
=
null
;
console
.
log
(
"
tried to open something
"
);
console
.
log
(
"
tried to open something
"
);
},
false
},
false
);
);
...
...
This diff is collapsed.
Click to expand it.
pd/nw/todo.txt
+
12
−
11
View file @
e01b09c3
...
@@ -21,18 +21,17 @@ Event settings for edit mode
...
@@ -21,18 +21,17 @@ Event settings for edit mode
*need to be able to tell the difference between new obj and retexted
*need to be able to tell the difference between new obj and retexted
obj
obj
Problems to put off until all (or most) sys_vgui calls are eliminated:
1) gui-side parser inside -- pdgui.js. Currently we're splitting on newlines so we can separate
gui_vmess from sys_vgui calls. This makes it very difficult to handle multi-line msg and text
boxes.
2) Semicolons -- currently the parser can't tell the difference between semicolons inside symbols
and semicolons that end statements. Again, this will be easy to solve once we eliminate sys_gui.
HTML5 which may not be standard yet:
HTML5 which may not be standard yet:
1) mouse.pageX/pageY -- exist in Chromium but maybe not in FF et al.
1) mouse.pageX/pageY -- exist in Chromium but maybe not in FF et al.
2) svg 'overflow' attribute -- probably doesn't work in other browsers
2) svg 'overflow' attribute -- probably doesn't work in other browsers
3) document.body.scrollTop (might be Chromium-specific, not sure)
3) document.body.scrollTop (might be Chromium-specific, not sure)
3) document.body.scrollLeft (might be Chromium-specific, not sure)
4) document.body.scrollLeft (might be Chromium-specific, not sure)
Problems to put off until all (or most) sys_vgui calls are eliminated:
[x] gui-side parser inside -- pdgui.js
[ ] Semicolons -- currently the parser can't tell the difference between
semicolons inside symbols and semicolons that end statements. Again,
this will be easy to solve once we eliminate sys_gui altogether
Node-webkit stuff:
Node-webkit stuff:
1) popup API
1) popup API
...
@@ -44,10 +43,12 @@ Node-webkit stuff:
...
@@ -44,10 +43,12 @@ Node-webkit stuff:
Everything else: (A [x] means we've fixed it)
Everything else: (A [x] means we've fixed it)
[ ] packaging as app, setting correct appname, etc
[ ] packaging as app, setting correct appname, etc
[ ] get -unique to work (relied on tcl [send] command)
[ ] get -unique to work (relied on tcl [send] command)
[ ] check if patch windows with screenposition (0,0) get stuck underneath Ubuntu/OSX menu. If so,
[ ] check if patch windows with screenposition (0,0) get stuck underneath
Ubuntu/OSX menu.
[ ] Node-webkit has a "screen" interface to retrieve the "workable" area of the screen
[ ] Node-webkit has a "screen" interface to retrieve the "workable" area of the screen
[x] choosing the same directory multiple times doesn't work (see dialog API page)
[x] choosing the same directory multiple times doesn't work
[ ] "Save As" on an overwrite doesn't seem to clear the dirty flag
(see dialog API page)
[x] "Save As" on an overwrite doesn't seem to clear the dirty flag
[ ] figure out why there is a "pd_opendir" global var
[ ] figure out why there is a "pd_opendir" global var
[ ] pass k12 mode arg
[ ] pass k12 mode arg
[ ] implement recent files (using Pd's prefs loading mechanism instead of reimplementing gui prefs)
[ ] implement recent files (using Pd's prefs loading mechanism instead of reimplementing gui prefs)
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment