port from Pd Vanilla (some of these were already ported): 5a1b58
These bugs were discovered via static code-analysis https://scan.coverity.com/projects/pure-data-pure-data (The CID numbers are the "Coverity IDs" used to identify the various bugs) - Don't free binbuf within glist_readfrombinbuf (CID:74871) - it must be deleted by the caller - Initialize sockaddr_in (CID:74861,74862,74863,74866) - Initialize indelay/outdelay (CID:74864,74865) - Initialize device-arrays (CID:74853,74854,74855,74856) - Closing unneeded sockets (CID:74827) - Initialize sockaddr_in (CID:74860} - Close file-descriptor if the soundfile is unparsable (CID:74822,74823) - Close file-handle in cleanup (CID:74816) - Call va_end() when handling variadic args (CID:74872) - Added missing break (CID:74800) - Prevent NULL-dereferences (CID:74792,74793) - Size checks when copying into string buffers (CID:74844,74845,74846,74847,74849) - Freeing no-more used storage (CID:74832) - Fixed code block (CID:74806) - Initialize sockaddr_in (CID:74860) - Initialize array-values to 0 (CID:74867) - Free allocated memory (CID:74813,74830) - Removed allocation of unused memory - Use pd_free() to free templates (CID:74814) - template_free() does not free the entire structure (it misses the pd_new() part) - initialize variable (CID:77865) - Prevent NULL-pointer dererencing (CID:77864) - Free heap-allocate binbuf after use (CID:74833)
Showing
- pd/src/d_soundfile.c 12 additions, 6 deletionspd/src/d_soundfile.c
- pd/src/g_canvas.c 2 additions, 2 deletionspd/src/g_canvas.c
- pd/src/g_editor.c 3 additions, 1 deletionpd/src/g_editor.c
- pd/src/g_readwrite.c 6 additions, 3 deletionspd/src/g_readwrite.c
- pd/src/g_template.c 1 addition, 1 deletionpd/src/g_template.c
- pd/src/m_binbuf.c 11 additions, 7 deletionspd/src/m_binbuf.c
- pd/src/m_class.c 1 addition, 1 deletionpd/src/m_class.c
- pd/src/m_pd.c 1 addition, 0 deletionspd/src/m_pd.c
- pd/src/s_audio.c 9 additions, 0 deletionspd/src/s_audio.c
- pd/src/s_audio_alsa.c 1 addition, 1 deletionpd/src/s_audio_alsa.c
- pd/src/s_inter.c 2 additions, 2 deletionspd/src/s_inter.c
- pd/src/s_path.c 3 additions, 2 deletionspd/src/s_path.c
- pd/src/u_pdreceive.c 1 addition, 1 deletionpd/src/u_pdreceive.c
- pd/src/u_pdsend.c 1 addition, 1 deletionpd/src/u_pdsend.c
Loading
Please register or sign in to comment