Commit 7cfac026 authored by Jonathan Wilkes's avatar Jonathan Wilkes
Browse files

allow class_addcreator to register an additional creator with the namespace prefix if one was used

This will allow legacy externals like iemmatrix and zexy to properly load
aliases the first time when the user instantiates an object with

This becomes relevant when there are kludge classes that essentially just
"#include" the original C file of a class and add an alias_setup function
which just calls the original setup routine. (For example, see iemmatrix.)
However, such an approach still calls class_new with the original class name.
Thus "namespace_prefix/classname" gets added to the pd_objectcreator
methodspace, but "namespace_prefix/alias_name"-- which is what we want--
does not. This results in a series of 1000 recursive calls into
pd_objectmaker's new_anything method. (I.e., sys_load_lib finds the
"namespace_prefix/classname" is already loaded, new_anything_sends a
typedmess to pd_objectmaker's new_anything method, which calls
sys_load_lib, etc.)

To prevent this, we just make sure to add "namespace_prefix/alias" by
adding the relevant lines to class_addcreator. This should really be
happening anyway-- since internal classes don't have a class_loadsym
they aren't affected, and externals with aliases won't work with
namespace prefix without this.
parent 3964dea2
Pipeline #914 failed with stage
in 6 minutes and 51 seconds
......@@ -318,6 +318,18 @@ void class_addcreator(t_newmethod newmethod, t_symbol *s,
class_addmethod(pd_objectmaker, (t_method)newmethod, s,
vec[0], vec[1], vec[2], vec[3], vec[4], vec[5]);
if (class_loadsym)
/* if we're loading an extern it might have been invoked by a
longer file name; in this case, make this an admissible name
too. */
char *loadstring = class_loadsym->s_name,
l1 = strlen(s->s_name), l2 = strlen(loadstring);
if (l2 > l1 && !strcmp(s->s_name, loadstring + (l2 - l1)))
class_addmethod(pd_objectmaker, (t_method)newmethod,
vec[0], vec[1], vec[2], vec[3], vec[4], vec[5]);
void class_addmethod(t_class *c, t_method fn, t_symbol *sel,
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment