Skip to content
Snippets Groups Projects

Fix up the nwworkingdir of the help browser's file browser (fixes #237).

Merged Albert Gräf requested to merge aggraef/purr-data:fix-osx-doc-path into master

Merge request reports

Merged by avatar (Apr 3, 2025 1:33am UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Author Developer

    Still works in Linux. Also, I can get rid of that ominous gui_dir variable now, which wasn't used anywhere else (wonder what it was good for in the first place, the rest of the help browser code already used pdgui.get_lib_dir() anyway). Stay tuned.

    Edited by Albert Gräf
  • Albert Gräf added 1 commit

    added 1 commit

    • bd2583de - Get rid of the gui_dir variable which is now obsolete.

    Compare with previous version

  • Author Developer

    Ok, everything looking good over here, on both Linux and Mac. Could you please test on Windows, to check that it still works there as well, and merge? (To test, just open the help browser and click the folder button, it should open in .../doc.)

    I'll get some sleep and then have a look at the cwd mismatch between GUI and engine on OSX. That shouldn't be too hard to fix either, and then the Mac version should be in good shape.

    In the meantime, maybe you could have a look at my other pending merge request !69 (merged) and merge that as well? Thanks.

  • Albert Gräf unmarked as a Work In Progress

    unmarked as a Work In Progress

  • mentioned in issue #220 (closed)

Please register or sign in to reply
Loading