Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • P purr-data
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 363
    • Issues 363
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 54
    • Merge requests 54
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Jonathan Wilkes
  • purr-data
  • Merge requests
  • !88

Merged
Created Mar 18, 2017 by Albert Gräf@aggraefDeveloper

About patch (fixes #248)

  • Overview 14
  • Commits 2
  • Changes 38

As discussed in #248 (closed). Tested on Linux (Arch) and macOS (Sierra). Here's how it looks like on Linux:

about-linux

Notes:

  • @pd_help didn't work on the Mac for me, so I used @pd-extra/../doc for the local links instead for now. (I think that we should take a look at the expansion of @pd_help some time, I don't think that the current implementation is correct.)

  • I simply added all the cat_thing pngs, but only a small (and constant) subset of those is actually used for the little animation right now. So there's still ample opportunity to beef this up. I'm not much of a graphics artist, so feel free to rework it as you see fit. :)

  • I'm not sure about the status of these included graphics. Did you create them yourself? Then you might want to add a license note there (Creative Commons maybe?). Otherwise, can we freely redistribute them?

  • Rev. 87d85e57 adds some cp commands to makefile.in and makefile.mingw so that the graphics files are installed along with the about patch. I hope that the changes in makefile.mingw will do the job, but as usual I couldn't test there, so it would be nice if you could give it a whirl on Windows (if the about patch comes up empty, then it's most likely due to a goof in the added line in makefile.mingw).

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: about-patch