Ivica Bukvic authored 4 years ago and Albert Gräf committed 4 years ago

* Created new and hopefully improved dialogs that should work on all
  three OSs. These include improved margins, optimal sizes that account
  for OS-specific idiosyncrasies, use of non-native toplevel window
  titlebars that cause bunch of issues (e.g. ability to maximize a
  dialog window since nw.js, at least in the earlier versions, has
  spotty support for disabling those), fixed window sizes with minimal
  scrollbars where appropriate, proper spacing between items, better
  positioning of the checkbox and radio buttons, etc.

* Enabled CTRL+W for the search dialog.

* Improved and consistent find bar appearance on all windows (console,
  patch, search).

* Refined activated box to match different zoom levels and font
  sizes. Small discrepancies still exist when using both custom fonts
  and zoom levels, but these are now no more than pixel off, whereas
  before it was all over the place.

* Made sure that patch windows on all OSs are exactly the same size,
  even when using custom zoom levels and fonts.

* Replaced the use of the legacy font menu with the native sub-menu and
  adjusted its behavior accordingly, including updating its values at
  patch open (the same method may prove useful in dealing with the
  undo/redo and other options not being registered properly because they
  may be running before the menu has been created).

* Refined the scrollbar behavior by providing a grab cursor when
  hovering and clicking on them. Also added dynamic updates to scrollbar
  colors (normal, hover, and click).

* Epic hack for making message boxes consistent size when activated.

* Made redrect on a GOP subpatch appear and disappear intelligently when
  dealing with subpatches populated exclusively with scalars. For
  instance, creating an empty object does not create a redrect yet
  because the user may be instantiating another instance of a
  scalar (e.g. a pony). However, once a non-data object has been created
  that wants to be displayed on the parent window inside GOP of the
  subpatch it is a part of, it toggles on. Similarly, once every
  non-scalar object has been deleted, the redrect disappears. There is
  still a lingering question why would one want to do this, but hey, who
  am I to judge?

* Fixed problem where a non-GOP text object got diagonal and y resize
  arrows that triggered consistency check.

* Fixed consistency check where resizing a GOP on the parent window
  using bottom-right corner cursor hotspots, triggered an error when the
  subpatch is also open. Now, everything resizes as it should
  concurrently, regardless of whether this is done on the subpatch or
  the parent window. As a bonus, the properties window reflects changed
  values regardless how they are being changed.

* Better iemgui number2 text offset across different font sizes and zoom
  levels.

* I think that is about it, although I may have missed something...

*reenabled checking for duplicate rtext activation which may be responsible for weird stale objects being created when quickly selecting and deselecting.
*small typo fix

*Added global connectme flag that allows for irregular/unusual objects to be properly positioned when being autopatched. This also deals with objects that do not have their top-left corner aligned with the (0,0) coords.

Improve bendin compatibility with vanilla.

See merge request jwilkes/purr-data!489

Correct some errors and add a note about vanilla compatibility options.

This adds an option to make bendin use the vanilla range of 0..16383 for
compatibility. As was observed a long time ago, this is at odds with the
bendout range of -8192..8191, and was thus fixed in pd-l2ork at some
point. But Miller Puckette has decided that this bug won't *ever* be fixed in
vanilla, and this is even documented in vanilla's midi-help.pd patch.

This discrepancy breaks a lot of patches involving MIDI, so a compatibility
option is needed. It's been possible to use -legacy to get vanilla's bendin,
but it's better not to conflate legacy iemgui positioning issues with the
bendin implementation. The former won't usually break interoperability, but
the latter does.

So, as suggested by Ico Bukvic, we add a flag as an optional second argument
to bendin instead. If present, this option explicitly denotes the target
range: zero means the default (pd-l2ork, signed) output range, nonzero the
vanilla-compatible unsigned range. In addition, there's a new -legacy-bendin
command line option which makes unsigned output the default for bendin objects
which don't specify the range explicitly. You'll want to put this into your
startup flags in the preferences if you need out-of-the-box vanilla
compatibility.

Merge branch 'guillembartrina/purr-data-feature_abstractionsaving_final' into feature-abstractionsaving

Disable nwworkingdir workaround in gui_canvas_saveas for nw.js 0.46+, fixes the first bug reported in #669.