- Disable touch-scrolling in situations where it interferes with other
  actions, like operating a slider, or dragging objects or the selection
  rectangle in edit mode.

- Truncate fractional touch coordinates which were causing glitches in the
  FUDI interface.

- Make dragging of iemgui labels and scalar draggables work (kind of).

TODO: Dragging (specifically in edit mode) can be a bit tricky in cases where
it's difficult to hit the right spot to initiate the drag action. This
*might* be solvable by making the algorithm identifying these spots a bit more
lenient, and accept touches which are a bit off.

Also, despite my best efforts, dragging iemgui label handles in edit mode
still needs quite some faffing about when using touch: After clicking the
iemgui object to make the handle appear, you first need to drag the handle a
little (horizontally, vertically, or diagonally) to make the corresponding
drag cursor appear, then release and touch the drag cursor *again* to drag the
handle to its final destination (and the label along with it). It goes without
saying that this seems overly complicated, but there doesn't seem to be an
easy way to work around this in the GUI, as the whole process goes back and
forth between GUI and engine in several steps in the current implementation.

Fixes the regression where the viewport is way too large after an optimal zoom operation (cf. #660).

* b_sym field to t_textbuf
* 2nd inlet and "send" method for text define
* text insert class
* improve a stray evalfile error
* show the [text] name (if it exists) in the title for the window
* updates help doc accordingly

Ivica Bukvic authored 4 years ago and Albert Gräf committed 4 years ago

Fixed regression from the plot fixes that broke non-plot scalars. TODO: check if non-plot scalar matrix needs to be tweaked...

Fixed centering of the closing prompt, removed shadow and increased opacity of the background dimming.

Cosmetic fixes to respond to changes to nw 0.46.2 behavior. Namely, fixed main purr-data window starting location and size and windows now restore where they are supposed to. Also disabled debugging output.

First checkpoint in implementing custom scrollbars and improving the scrollbar behavior. This is a WIP that requires nw.js 0.46.2.

Finished second stage of the scrollbar implementation and added scrolling with middle click. All scrollbars are now operational and to the best of my knowledge accurate. The only things remaining are: getscroll needs to be called on deselect to recalculate when the handles are erased on objects that have them (we should get rid of these and focus on bboxes instead), responding to maximizing and restoring, and addressing a weird bug where in 0.46.2 patches are saved with larger window sizes under certain conditions.

Reverted scrolling by grabbing due to problematic relationship between scrollBy and the zoom factor

Continuing work on the scrollbars. The only known thing now remaining is ensuring that the patch window is properly recorded when saving it (under certain conditions it spits out completely wrong values

Removed debug printouts

Finished the scrollbars. The only thing remaining is for someone who has a better understanding of the pd_canvas.js and how the events are captured, to refactor my registration of events that ensure scrollbars are clickable and the onresize event. Currently, they are embedded inside the pd_canvas.js under the body tag where you will find both onscroll and onresize events.

Overhaul of the new scrollbars to further improve their behavior, enable as perfect of a fit of the plots both in gop and on toplevel, and dynamic updating of the plots in toplevel when resized. Reworked dynamic event adding/removal for the scrollbars and removed onscroll from the html document and moved it into the pd_canvas.js. Still need to add a delay for the backend callback to update the scrollbars on the toplevel plot/array and thereby remove scrollbar flicker.

Finished implementing the scrollbar callback and addressed popup not appearing in the right place (likely due to upgrade to 0.46.2)

Added names of arrays to their toplevel subpatch window title. Multiple arrays are listed in the order they have been added.

Another reworking of scrollbars to and array sizing to capture all possible scenarios. Some refactoring to make use of the canvas_hasarray. Remaining known issues pertaining to the plots are:
*array toplevel windows are not restored in position they were saved
*last element on the plots is not clickable
*make bezier plot look like bezier (may need to leverage curve_path)

Jonathan Wilkes authored 4 years ago and Ivica Bukvic committed 4 years ago

* give new cord the same color as selected line (except for vanilla/ext presets)
* make broken object stand out more
* make comment dash sizes match l2ork 1.0
* change xlet hover animation to match new xlet style

Disabled moving canvas with arrows in non-edit mode since we may want to use those keys through the [key] object. Later we can expose scroll ability to use key object to drive scrolling...

Various cosmetic improvements that deal primarily with proper highlighting of object borders, with particular focus on comments. See comments in the code for more info.

Proper fix for the nlet highlighting. Now allows for loose aiming and always starts the patch cord at the center of the outlet. Inlets from which we currently cannot connect from are grey when highlighted, while ones you can initiate connection from are orange (both colors are themeable inside the css). Also, if trying to connect an impossible connection (signal to non-signal), when hovering over the non-signal inlet during the connection cycle, such an inlet will be also highlighted gray (grey? whatever...). Lastly, updated the highlighting animation--I am really not particularly interested in animation as it tends to slow down the interaction with the patch, so the animation is much shorter and more minimal. Potential value is leaving it as this to provide visibility of the nlet being highlighted when we are already over it with the cursor, which will otherwise occlude the nlet altogether. Another consideration with the currently committed highlight is that it is hollow inside which looks IMO distracting. Curved edges is also distracting since no other aspect of the UI (save for the customized data structures created by the user) is not curved.

Long and painful journey to make all plots fit into a GOP graph is (hopefully) complete. One thing I did not test is having multiple plots in a single GOP, even though it should work ok as long as each scalar group is treated as separate.

Improved variable wording and removed extraneous printouts.

* give new cord the same color as selected line (except for vanilla/ext presets)
* make broken object stand out more
* make comment dash sizes match l2ork 1.0
* change xlet hover animation to match new xlet style

Improved consistent drawing of box sizes between edit and display modes, adjusted positioning of text both in text and graph objects, provided consistent spacing on the left and right sides. TODO: work on auto-updating GOP gray rectangle when its size is adjusted through the sub-patch, as is the case with the 1.x branch.