Our 32 bit Windows installer currently installs some binaries (dll and
exe files) in the Windows system32 directory. This is unnecessary (all
required dlls are already in the program bin directory where pd.exe will
readily find them), and actually a nuisance, since we currently don't
remove some of the dlls in system32 again when uninstalling, causing a
lot of inconvenient prompts from the installer when upgrading or
reinstalling.

If the user wants to run cyclist, pdreceive, or pdsend from whatever
command line he uses, he can easily add the program bin directory to
PATH himself. That's much better than having our installer pollute the
system32 directory.

The mingw64 build already does it that way, here we simply apply the
same fixes to the mingw32 build.

In one fell swoop, this solves all usability issues we have with the
Ctrl key we currently employ for that purpose, which interferes with all
our menu keybindings, and makes temporary run mode unusable on the Mac.

Make Ctrl+F work if the canvas is in edit mode. In this case,
canvas_key(), upon receiving the Ctrl keydown event from the Ctrl+F
shortcut, temporarily switches to run mode, but never gets the
corresponding keyup event which goes to the findbox, so temporary run
mode remains in effect when the findbox opens.

This shouldn't actually be much of a problem, but the real trouble is
that while canvas_key() informs the GUI about the change to run mode, it
doesn't update the state of the canvas-local gl_edit variable
accordingly. So when dofind() switches on edit mode later, the engine
still thinks that it's in edit mode and thus doesn't trigger the
necessary update.

The easy fix is to just update gl_edit in canvas_key() when edit mode is
temporarily disabled.

This gets rid of some race conditions in the find operation, by ensuring
that edit mode is only updated *after* mapping a subpatch window.

This bug manifested itself when searching for objects in subpatches
which are not visible at the time the find operation gets invoked. In
this case, on the GUI side we both have to create the subpatch window
and put it in edit mode. In the previous implementation these two
operations would be executed separately and asynchronously. The end
result was that usually the latter operation setting the edit mode in
the GUI would win out, and the edit mode would later get overwritten
again when the window was created.

We fixed that race condition by ensuring that the engine is queried for
its current edit mode status after creating a canvas window. The engine
replies with a call to gui_canvas_set_editmode() in the GUI and thus the
edit mode in the GUI now properly reflects the status in the engine
after a window is mapped.

TL;DR: This fix should now make sure that edit mode on the GUI side
reflects that of the engine at all times.

This makes Ctrl+F work again, by making sure that edit mode is set
correctly in the GUI even if glob_ctrl is set (because the Ctrl key up
event goes to the find box and is thus is never received by the canvas).

The build directory needs to be cleaned out for a subsequent rebuild to work in the Darwin app build.

* Tab bar is 100% width

* Startup tab has proper right margins

* Startup tab buttons are properly aligned

* All select (dropdown) boxes are the same height as the numboxes

* Better spacing on midi in and out labels and between select boxes

* Better spacing and sizing on the audio input and output select boxes, associated channel numbers, and labels

* More spacing between audio input and output

Albert Gräf authored 4 years ago and Albert Gräf committed 4 years ago

Time to say goodbye to Windows XP. Use our default nw.js version on Windows instead of the ancient 0.14.7.

The library regression test now accepts 2176 objects for a successful test,
which is the number we currently have for mingw64 (down from the previous
value of 2251).

Albert Gräf authored 4 years ago and Albert Gräf committed 4 years ago

This is useful, in particular, to print out pointer values with the
%zx specifier, since it prevents the annoying format warnings when
using %zx with t_int.

Albert Gräf authored 4 years ago and Albert Gräf committed 4 years ago

This can be seen, e.g., when running regression_tests.pd gui-less in
Windows, as our CI script does. The easy fix is to just bypass the gui
finalization code in glob_quit() when running gui-less (sys_nogui).